WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 12 months ago

Last modified 5 months ago

#37507 closed defect (bug) (fixed)

Can't delete empty line between visual shortcodes.

Reported by: andyspw Owned by: azaozz
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.6
Component: TinyMCE Keywords: has-patch needs-testing
Focuses: Cc:

Description

I can't delete empty line in TinyMCE between visual shortcodes in WP 4.6 RC1. I think, this behavior isn't correct.

To reproduce:

  • create two galleries
  • add an empty line between them
  • put a cursor to this line
  • click "Delete" button

Instead of an empty line, the second gallery will be deleted.

http://g.recordit.co/J6stThLiyE.gif

Attachments (1)

37507.patch (2.3 KB) - added by NickDuncan 13 months ago.
Modified tinymce.js to suit the changes made in the commit on https://github.com/tinymce/tinymce/commit/68d6c78ff14c038d40c791b7940d87e731d90fc3

Download all attachments as: .zip

Change History (11)

#1 @azaozz
14 months ago

  • Milestone changed from Awaiting Review to Future Release

Hi @andyspw, thanks for the bug report. I can reproduce it.

This is a bug "upstream" in the TinyMCE editor. I've reported it to the developers there. For now the workaround is to drag the bottom gallery to that empty paragraph. It will be fixed in WordPress after it is fixed in TinyMCE and we upgrade to that version.

#3 in reply to: ↑ 2 @azaozz
14 months ago

  • Milestone changed from Future Release to 4.7

Replying to ocean90:

Yes, however I'm hesitant updating TinyMCE to the latest dev. build or backporting this fix few days before the 4.6 release. This is somewhat annoying but is an edge case that has workarounds.

@NickDuncan
13 months ago

Modified tinymce.js to suit the changes made in the commit on https://github.com/tinymce/tinymce/commit/68d6c78ff14c038d40c791b7940d87e731d90fc3

#4 @NickDuncan
13 months ago

  • Keywords has-patch needs-testing added

#5 follow-up: @jorbin
12 months ago

I've opened #38081 to update TinyMCE which should resolve this issue.

This ticket was mentioned in Slack in #core by stevenkword. View the logs.


12 months ago

#7 in reply to: ↑ 5 @stevenkword
12 months ago

Replying to jorbin:

I've opened #38081 to update TinyMCE which should resolve this issue.

Per #38081 ticket, @azaozz mentions that we can go ahead and update to the latest version of TinyMCE, but will need to do it again before beta once there is another update.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


12 months ago

#9 @azaozz
12 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

This ticket was mentioned in Slack in #core-tinymce by azaozz. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.