Opened 8 years ago
Closed 8 years ago
#37520 closed defect (bug) (fixed)
Remove @since references to "Menu Customizer"
Reported by: | celloexpressions | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | good-first-bug has-patch |
Focuses: | docs | Cc: |
Description
I just noticed that there are some @since references to "Menu Customizer" in wp-admin/js/customize-nav-menus.js
. These should have been changed to @since 4.3.0
when the Menu Customizer plugin was merged into core. Might be worth searching for this in other files as well.
Attachments (2)
Change History (9)
#2
@
8 years ago
- Focuses docs added
Thanks for the patch @gma992!
@DrewAPicture do we need the empty line above the @since
? Does everything else look good to you here?
#3
@
8 years ago
- Owner set to gma992
- Status changed from new to assigned
@celloexpressions The "blank line above the @since
" is where the (missing) short descriptions live ;)
Assigning to mark the good-first-bug as "claimed."
#4
follow-up:
↓ 5
@
8 years ago
Actually, looks like most of the functions have ashort description but it's now below @since. @gma992 do you want to take a stab at adding descriptions where they're missing? If not I can add those to your patch. And then I think the @since should go under the descriptions where they occur, since they're all probably intended to be short descriptions.
#5
in reply to:
↑ 4
@
8 years ago
Replying to celloexpressions:
Indeed, as @DrewAPicture says the empty space is intended to write down the missing descriptions, feel free to go ahead and modify whatever you feel like :)
changed to @since 4.3.0 Menu Customizer and some formatting love