Make WordPress Core

Opened 20 years ago

Closed 17 years ago

#3753 closed enhancement (fixed)

Kubrick should allow comments for pages if check marked

Reported by: anonymized_154007 Owned by:
Priority: normal Milestone: 2.9
Component: Template Version: 2.1
Severity: normal Keywords: theme kubrick page has-patch tested commit
Cc: Focuses:

Description

Wordpress allow comments on pages. Everything in the code or the user interface indicate this.

Unfortunately it's impossible to add comments on a static page that allow them. At least it's impossible "out of the box" with default (aka Kubrick) theme.

My trivial patch add a comment form and comment list on every static page diplayed in Kubrick theme. This patch was tested on Wordpress 2.0.x and 2.1.

Attachments (3)

wp-default-theme-show-comments-on-pages.diff​ (298 bytes ) - added by anonymized_154007 20 years ago.
Patch to display comments on static page with Kubrick theme.
wp-default-theme-show-pages-comments-or-pingbacks.diff​ (460 bytes ) - added by anonymized_154007 20 years ago.
Fix diff path. Sorry.
3753.diff​ (413 bytes ) - added by Denis-de-Bernardy 18 years ago.

Download all attachments as: .zip

Change History (14)

@anonymized_154007
20 years ago

Patch to display comments on static page with Kubrick theme.

#1 @foolswisdom
20 years ago

  • Keywords has-patch added
  • Summary Hidden coments on static pages → Kubrick should allow comments for pages if check marked

ENV: WP trunk (2.2-bleeding) r7842
Confirmed bug
Tested patch.

Coolkevman, Thank you! in the future please provide patches from the root of the project, so instead of the page file being for 'page.php' it is for 'wp-content/themes/default/page.php'

#2 @Nazgul
20 years ago

  • Milestone 2.1.1 → 2.2
  • Type defect → enhancement

#3 follow-up: @foolswisdom
20 years ago

  • Keywords has-patch comment removed
  • Milestone 2.2
  • Resolution → wontfix
  • Status new → closed

Close WONTFIX.

Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)

#4 in reply to: ↑ 3 @anonymized_154007
20 years ago

Replying to foolswisdom:

Close WONTFIX.

Noticed that for pages you would want to first check if ( comments_open() ) because "Comments are closed." would not be desirable, anyway can't really make a change like this for default theme, because of change in behavior for people upgrading. (This patch could be included in a fix for #3756)

Ok, so if I understand a patch like the one I've just uploaded (wp-default-theme-show-pages-comments-or-pingbacks.diff) is not acceptable ?

#5 @darkdragon
19 years ago

  • Milestone → 2.5
  • Resolution wontfix
  • Status closed → reopened

Reopening for 2.5 to allow for patch to be debated again.

#6 @darkdragon
19 years ago

  • Keywords has-patch added

#7 @Denis-de-Bernardy
18 years ago

  • Keywords tested commit added
  • Milestone 2.9 → 2.8

uploaded a refreshed patch against today's trunk. please commit this or wontfix it, so as to trim ticket clutter

#8 @westi
18 years ago

  • Resolution → wontfix
  • Status reopened → closed

Kubrick has been like this forever.

I don't see a need to change this now.

#9 @westi
17 years ago

  • Cc josephscott added

#10 @westi
17 years ago

  • Milestone 2.8 → 2.9
  • Resolution wontfix
  • Status closed → reopened

For the theme repo we require support for Pages with Comments - ​http://codex.wordpress.org/Theme_Development_Checklist#Page_with_comments

Therefore default should do so as well.

Re-opening for 2.9.

#11 @westi
17 years ago

  • Resolution → fixed
  • Status reopened → closed

(In [11885]) Comments for default theme Pages. Fixes #3753.

Note: See TracTickets for help on using tickets.