Changes between Initial Version and Version 1 of Ticket #37531, comment 7
- Timestamp:
- 08/01/2016 01:55:27 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #37531, comment 7
initial v1 1 [attachment:37531.diff] fixes the `modal-open` class to be used. If the filesystem credentials modal isn't printed out, do not attempt to show it. (sorry about the stripped-out trailing spaces, I just noticed my code editor removed them)1 [attachment:37531.diff] fixes the `modal-open` class to be used. If the filesystem credentials modal isn't printed out, do not attempt to show it. (sorry about the trailing spaces, I just noticed my code editor messed them up) 2 2 3 3 However, another problem here is that the directory already existing is actually not a filesystem credential error IMO. Even on a setup which allows direct filesystem access, this problem may appear - requesting filesystem credentials wouldn't fix it. Therefore, in [attachment:37531.2.diff] I modified the upgrader class to store this specific error in the `$result` property so that it is used by the AJAX function `wp_ajax_install_plugin()`.