Opened 8 years ago
Closed 8 years ago
#37540 closed enhancement (fixed)
validateForm does not validate textarea or select inputs
Reported by: | shadyvb | Owned by: | swissspidy |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Administration | Keywords: | has-patch |
Focuses: | ui, javascript | Cc: |
Description
validateForm only looks for <input /> elements and ignores select and textarea fields.
Steps to reproduce:
- Add a select or textarea input to term edit page/form, add 'form-required' class to their wrappers
- Leave the new field(s) empty
- Click the submit button
Expected behavior:
- Form is not submitted, because required fields are not filled out
Actual result:
- Form validation passes and form is submitted
Recommended change:
- Change
input:visible
to:input:visible
so it covers select and textarea as well.
Attachments (1)
Change History (6)
Note: See
TracTickets for help on using
tickets.
@shadyvb
Patch applies cleanly without any errors.