#37543 closed task (blessed) (fixed)
Update Twemoji for pirate and rainbow flags
Reported by: | pento | Owned by: | pento |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Emoji | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description (last modified by )
There's a minor update to Twemoji that adds support for the pirate and rainbow flags.
https://github.com/twitter/twemoji/commit/cae041df48a4365bd5d4e232af4859a2704e2dd9
The rainbow flag in an officially documented ZJW sequence, and can be implemented immediately, despite not being part of Unicode 9.0. It was just added to the iOS 10 beta, so we can assume it'll become more popular very soon.
The pirate flag is *not* an officially documented ZJW sequence, and I'm not aware of any other platforms supporting it at this time. I don't consider that to be an issue, as it doesn't break forwards compatibility (it's very unlikely that a different emoji would use the same ZJW sequence in the future, one would have to derive a different meaning from "skull/crossbones" + "black flag" to even suggest it).
Due to the minor nature of this change, I don't think we need to add an extra test to the twemoji loader, this can just be an update to the twemoji.js
regex.
Attachments (1)
Change History (9)
#4
@
8 years ago
- Keywords commit dev-reviewed added; 2nd-opinion removed
@pento 37543.diff looks good to me.
The assets have been deployed to the CDN.
The patch requires review and approval from another permanent committer.