WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#37544 closed enhancement (fixed)

Remove one-time variable $pieces for terms_clauses

Reported by: ocean90 Owned by: boonebgorges
Milestone: 4.7 Priority: low
Severity: minor Version:
Component: Taxonomy Keywords: has-patch
Focuses: Cc:

Description

$pieces is since [28736] only used in compact(). Having the extra variable makes the current code harder to read and can also confuse IDEs because they can't correctly evaluate whether a variable is used or not.

Attachments (2)

37544.png (209.8 KB) - added by ocean90 4 years ago.
37544.patch (993 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
4 years ago

@ocean90
4 years ago

#1 @boonebgorges
4 years ago

  • Milestone changed from Awaiting Review to 4.7

#2 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 38377:

Eliminate unnecessary variable in WP_Term_Query.

Props ocean90.
Fixes #37544.

Note: See TracTickets for help on using tickets.