Twenty Twelve IE stylesheet: Missing CSS

[superpoincare]

Twenty Twelve's CSS requires this code to be consistent with the design in other browsers:

.site-header h1 {
	margin-bottom: 0;
}

This style can be added in the css file ie.css in the folder css.

This can be added after this line: ​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwelve/css/ie.css#L70

[Presskopp]

Well, if you say so :) I had the time to make a patch ;) - so here it is:

[superpoincare]

Nice. Also, realised that there's another place to have a difference. Enqueued style will need a different query string (date?) ​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwelve/functions.php#L155

[Presskopp]

I don't know the rules of adding the date, but I did.

@superpoincare Do you have some more information about the problem/your solution. I guess at least it will not hurt to move this ticket forward. I just did the patch, not understanding the issue.

[SergeyBiryukov]

Hi @superpoincare, could you add screenshots for this change and specify IE version?

[superpoincare]

Hi Sergey,

It affects IE versions below 9.

This happens because in the mobile-first part of the style.css with no media query, sets a margin.

​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwelve/style.css#L571

Then within media queries, it is set to zero.

​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwelve/style.css#L1510

The sheet for IE less than IE9, i.e., IE6-8 then forgets to set it to zero.

Attaching two screenshots. One for IE 8 and the other for Edge 13

(I don't know how to attach images here, so I am linking it to imgur, sorry!)

​http://imgur.com/a/EJX4F

[karmatosed]

I'm trying to work out this issue so please allow me to ask a question that may not be relevant. If it only is around media queries, does it even fire off with IE 9? We also won't be going back as far as IE 8 for support at this point, IE 9 yes we do.

[superpoincare]

Yes, doesn't affect IE9 as the bug is in the conditional IE less than 9 stylesheet.

IE8 usage is low and I think Wordpress support for old browsers is that it should display well and not have errors, so current scripts and styles satisfy that. You may close this ticket.