Make WordPress Core

Changes between Initial Version and Version 8 of Ticket #37549


Ignore:
Timestamp:
01/07/2020 08:05:16 PM (4 years ago)
Author:
desrosj
Comment:

Moving this back to Awaiting Review.

@sterlo are you still interested in tackling this?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37549

    • Property Status changed from new to reviewing
    • Property Component changed from Upload to Media
    • Property Owner set to joemcgill
    • Property Milestone changed from to Awaiting Review
    • Property Keywords has-patch added
  • Ticket #37549 – Description

    initial v8  
    2121SVG files are displayable -- and `file_is_displayable_image` is a well meaning function but it's not really determining if a file is displayable. It's determining if an image will work with `getimagesize`.
    2222
    23 '''The Ask''': Let's allow developers to pass dimensions to `wp_generate_attachment_metadata` so that we allow for future file types that are web friendly to exist within Wordpress, with the support of plugins, and that useful information about those uploaded files is generated in a controllable and consistent manner.
     23'''The Ask''': Let's allow developers to pass dimensions to `wp_generate_attachment_metadata` so that we allow for future file types that are web friendly to exist within WordPress, with the support of plugins, and that useful information about those uploaded files is generated in a controllable and consistent manner.
    2424
    2525Right now, the recourse I have as a plugin developer is to copy `wp_generate_attachment_metadata` and generate my meta data within the plugin. Which I isn't a problem, but I feel this request nudges `image.php` into a direction it's going to need to go sooner or later anyway.