WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#3755 closed defect (bug) (fixed)

wp_title function: filter post title before stripping tags

Reported by: jhodgdon Owned by: rob1n
Milestone: 2.2.1 Priority: normal
Severity: normal Version: 2.1
Component: General Keywords: filter, wp_title, strip_tags, has-patch
Focuses: Cc:

Description

At least one plugin (Polyglot) uses special (fake HTML) tags for filtering purposes. In most places in WordPress, filters are called before stripping HTML tags out of titles. However, in the wp_title function, strip_tags is called before apply_filters, so the filtering does not work.

Patch about to be added...

Attachments (2)

general-template.php.diff (633 bytes) - added by jhodgdon 7 years ago.
Patch to wp_title function: strip tags after filtering post title
general-template-php4.diff (646 bytes) - added by jhodgdon 7 years ago.
Diff for re-patch of the fix that was submitted so it will actually work

Download all attachments as: .zip

Change History (10)

jhodgdon7 years ago

Patch to wp_title function: strip tags after filtering post title

comment:2 jhodgdon7 years ago

  • Keywords strip_tags has-patch added; stip_tags removed

comment:3 jhodgdon7 years ago

Still unpatched in [5012], same problem still there.

comment:4 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5014]) apply filter before stripping tags. Props jhodgdon. fixes #3755

comment:5 jhodgdon7 years ago

  • Cc jhodgdon added
  • Resolution fixed deleted
  • Status changed from closed to reopened

I just noticed that the way the patch was applied here, the function is still broken. The current file says ([5619] of general-template.php):

229 $title = apply_filters('single_post_title', $title);

230 $title = strip_tags($post->post_title);

As you can see, the second line overrides the first line. It should be (as it was in the original patch):

229 $title = apply_filters('single_post_title', $post->post_title);

230 $title = strip_tags($title);

I am submitting a new patch to fix this patch... will attach shortly...

Jennifer

jhodgdon7 years ago

Diff for re-patch of the fix that was submitted so it will actually work

comment:6 rob1n7 years ago

  • Owner changed from anonymous to rob1n
  • Status changed from reopened to new

comment:7 rob1n7 years ago

  • Milestone changed from 2.2 to 2.2.1

comment:8 rob1n7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5625]) Fix wp_title single post title filters. Props jhodgdon. fixes #3755

Note: See TracTickets for help on using tickets.