wp_title function: filter post title before stripping tags

[jhodgdon]

At least one plugin (Polyglot) uses special (fake HTML) tags for filtering purposes. In most places in WordPress, filters are called before stripping HTML tags out of titles. However, in the wp_title function, strip_tags is called before apply_filters, so the filtering does not work.

Patch about to be added...

[jhodgdon]

Patch to wp_title function: strip tags after filtering post title

[ryan]

1

[jhodgdon]

Still unpatched in [5012], same problem still there.

[ryan]

(In [5014]) apply filter before stripping tags. Props jhodgdon. fixes #3755

[jhodgdon]

I just noticed that the way the patch was applied here, the function is still broken. The current file says ([5619] of general-template.php):

229 $title = apply_filters('single_post_title', $title);

230 $title = strip_tags($post->post_title);

As you can see, the second line overrides the first line. It should be (as it was in the original patch):

229 $title = apply_filters('single_post_title', $post->post_title);

230 $title = strip_tags($title);

I am submitting a new patch to fix this patch... will attach shortly...

Jennifer

[jhodgdon]

Diff for re-patch of the fix that was submitted so it will actually work

[rob1n]

(In [5625]) Fix wp_title single post title filters. Props jhodgdon. fixes #3755