Shiny Updates: minor, edge case, visual glitch when bulk updating

[afercia]

Minor, edge case but worth considering. To reproduce:

• select at least one installed plugin to update checking its checkbox
• select "Update" from the Bulk Action select
• disconnect from the Internet :) to intentionally trigger an error
• press the "Apply" button to update
• an error notice will be displayed in the plugin row and one more notice on top of the page, let's focus on the one in the plugin row

Now, say the error was just temporary, a network hiccup or whatever and you want to retry to update so:

• reconnect to the Internet :)
• select again the plugin with the error notice still displayed in place
• select "Update" from the Bulk Action select
• press the "Apply" button to update

The error notice icon will start spinning (that's supposed to happen just for the "update available" icon) and the message "Updating..." appears with the error styling. Also, when the update completes, the success message "Updated!" will be displayed in the notice with the error styling.

[ocean90]

37550.patch​ fixes the random "error" message which isn't helpful at all. It reuses the string from the editor.

[ocean90]

Replying to ocean90:

37550.patch​ fixes the random "error" message which isn't helpful at all. It reuses the string from the editor.

Moved into #37583.

[ocean90]

See #37583.

[ocean90]

37550.2.diff​ is 37550.diff​ but without the error message part which has been moved into #37583.

[SergeyBiryukov]

Reproduced the issue and tested 37550.2.diff​. Looks good.

[ocean90]

In 38209:

Update/Install: Remove the .notice-error class before adding classes for the update process.

Prevents displaying an update message with error styling.

Props obenland.
Props SergeyBiryukov for review.
Fixes #37550.

[ocean90]

In 38210:

Update/Install: Remove the .notice-error class before adding classes for the update process.

Prevents displaying an update message with error styling.

Merge of [38209] to the 4.6 branch.

Props obenland.
Props SergeyBiryukov for review.
See #37550.