WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#37550 closed defect (bug) (fixed)

Shiny Updates: minor, edge case, visual glitch when bulk updating

Reported by: afercia Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.6
Component: Plugins Keywords: has-screenshots has-patch commit dev-reviewed
Focuses: ui, javascript Cc:
PR Number:

Description

Minor, edge case but worth considering. To reproduce:

  • select at least one installed plugin to update checking its checkbox
  • select "Update" from the Bulk Action select
  • disconnect from the Internet :) to intentionally trigger an error
  • press the "Apply" button to update
  • an error notice will be displayed in the plugin row and one more notice on top of the page, let's focus on the one in the plugin row

https://cldup.com/8n4kZCz1Mh.png

Now, say the error was just temporary, a network hiccup or whatever and you want to retry to update so:

  • reconnect to the Internet :)
  • select again the plugin with the error notice still displayed in place
  • select "Update" from the Bulk Action select
  • press the "Apply" button to update

The error notice icon will start spinning (that's supposed to happen just for the "update available" icon) and the message "Updating..." appears with the error styling. Also, when the update completes, the success message "Updated!" will be displayed in the notice with the error styling.

https://cldup.com/QelwY5vH4w.png

Attachments (4)

37550.patch (3.0 KB) - added by ocean90 3 years ago.
37550.png (73.5 KB) - added by ocean90 3 years ago.
37550.diff (3.4 KB) - added by obenland 3 years ago.
37550.2.diff (1.8 KB) - added by ocean90 3 years ago.
See #37583.

Download all attachments as: .zip

Change History (15)

#1 @ocean90
3 years ago

  • Keywords needs-patch added; shiny-updates removed

@ocean90
3 years ago

@ocean90
3 years ago

This ticket was mentioned in Slack in #feature-shinyupdates by ocean90. View the logs.


3 years ago

This ticket was mentioned in Slack in #feature-shinyupdates by ocean90. View the logs.


3 years ago

#4 follow-up: @ocean90
3 years ago

  • Milestone changed from Awaiting Review to 4.6

37550.patch fixes the random "error" message which isn't helpful at all. It reuses the string from the editor.

@obenland
3 years ago

#5 @obenland
3 years ago

  • Keywords has-patch added; needs-patch removed

#6 in reply to: ↑ 4 @ocean90
3 years ago

Replying to ocean90:

37550.patch fixes the random "error" message which isn't helpful at all. It reuses the string from the editor.

Moved into #37583.

@ocean90
3 years ago

See #37583.

#7 @ocean90
3 years ago

  • Keywords commit added

37550.2.diff is 37550.diff but without the error message part which has been moved into #37583.

This ticket was mentioned in Slack in #core by ocean90. View the logs.


3 years ago

#9 @SergeyBiryukov
3 years ago

  • Keywords dev-reviewed added

Reproduced the issue and tested 37550.2.diff. Looks good.

#10 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 38209:

Update/Install: Remove the .notice-error class before adding classes for the update process.

Prevents displaying an update message with error styling.

Props obenland.
Props SergeyBiryukov for review.
Fixes #37550.

#11 @ocean90
3 years ago

In 38210:

Update/Install: Remove the .notice-error class before adding classes for the update process.

Prevents displaying an update message with error styling.

Merge of [38209] to the 4.6 branch.

Props obenland.
Props SergeyBiryukov for review.
See #37550.

Note: See TracTickets for help on using tickets.