Shiny Updates: aria-label not updated on failure on plugins.php

[afercia]

When a plugin update on plugins.php fails, the plugin notice gets updated with an error message but the aria-label set on the paragraph still says "Updating {plugin name}...":

Instead, in plugin-install.php the aria-label gets correctly updated:

The fix looks simple, checking if a plugin name is returned in the response data:

• if yes, update the aria-label using the plugin name
• if not, it's a bit pointless to use an aria label in the first place, so remove it and let screen readers read the existing text

Worth noting, while theoretically aria-label can be used on any element, and in this case is used on a paragraph, some screen readers read this attribute only on focusable elements or elements with some specific aria role attributes. I don't see this as a big deal in this specific case: whether screen readers will announce the aria-label or the existing text, the important thing is to ensure the messages are appropriate.

Also, worth reminding aria-label completely overrides the existing element text.

VoiceOver does announce the aria-label set on the paragraph and ignores the existing text.

NVDA doesn't and reads out the existing text instead:

Patch incoming.

[afercia]

37556.diff​ introduces the proposed fix also for the plugin "cards" in plugin-install.php.

[ocean90]

37556.3.diff​ removes the aria labels if the Ajax response is invalid.

[afercia]

Note: during testing after the weekly dev chat @ocean90 noticed also other places where removing the aria-label would be appropriate because the element text is clear enough. He's kindly updating the patch :) Worth noting using the same text for both the element's text and the aria-label is a bit pointless and can be safely avoided. For example doing this on the same element:

.attr( 'aria-label', wp.updates.l10n.updateFailedShort )
...
.text( wp.updates.l10n.updateFailedShort );

[DrewAPicture]

37556.3.diff​ looks good.

[ocean90]

In 38196:

Plugins: Also update aria-labels when a plugin update fails.

Previously the label was stuck at "Updating…".

Props afercia, ocean90.
Props DrewAPicture for review.
Fixes #37556.

[ocean90]

In 38197:

Plugins: Also update aria-labels when a plugin update fails.

Previously the label was stuck at "Updating…".

Merge of [38196] to the 4.6 branch.

Props afercia, ocean90.
Props DrewAPicture for review.
See #37556.