#37583 closed defect (bug) (fixed)
Shiny Updates: Enhance error reporting when response is invalid
Reported by: | ocean90 | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Upgrade/Install | Keywords: | has-patch has-screenshots commit |
Focuses: | ui, javascript, administration | Cc: |
Description
wp.updates.isValidResponse() checks the Ajax response and tries to provide a meaningful error message in case of an error. This doesn't work always:
- Invalid nonce: "Update Failed: -1"
- Connection lost: "Update Failed: error" (see #37550 for a screenshot)
- 404 error: "Update Failed: $html" (https://cloudup.com/c-2MST8o_RE, unescaped in the admin notice)
Attachments (3)
Change History (9)
#2
@
8 years ago
- Keywords has-screenshots commit added
A 404 seems to be unlikely, it would mean that admin-ajax.php is gone. So the raw output should be fine here.
#4
@
8 years ago
37583.patch looks good but we may need to strip HTML from the passed error messages as they are escaped and would show. Got this by adding sleep(31) to wp-config.php
Update Failed: <br /> <b>Fatal error</b>: Maximum execution time of 30 seconds exceeded in <b>\test\wp-config.php</b> on line <b>45</b><br />
Note: See
TracTickets for help on using
tickets.
37583.patch: