WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 4 months ago

#37587 new enhancement

Inconsistency on deleting plugin/theme on WP 4.6

Reported by: olarmarius Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.4
Component: Themes Keywords: reporter-feedback
Focuses: administration Cc:

Description

On delete plugin admin-ajax call see
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/ajax-actions.php#L3821

the actions delete_plugin see
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/plugin.php#L846

and deleted_plugin see
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/plugin.php#L865

are missing from theme deletion.

Please consider adding this patch in 4.6 as the realease is imminent and the patch is realy just for the sake of consistency.

Attachments (1)

wordpress.patch.ticket.37587.diff (1.1 KB) - added by olarmarius 3 years ago.
Patch for 37587 ticket

Download all attachments as: .zip

Change History (5)

#1 follow-up: @ocean90
3 years ago

  • Focuses performance removed
  • Keywords reporter-feedback added

Hello @olarmarius, thanks for your report. I don't fully understand the issue (yet). Looks like you forgot to upload the patch?

This ticket was mentioned in Slack in #core by mario. View the logs.


3 years ago

#3 @SergeyBiryukov
3 years ago

  • Component changed from General to Themes
  • Type changed from defect (bug) to enhancement
  • Version changed from trunk to 4.4

Looks like the suggestion is to introduce delete_theme and deleted_theme actions.

delete_plugin and deleted_plugin were added in [35094] and [35669], so it's not a regression in 4.6.

@olarmarius
3 years ago

Patch for 37587 ticket

#4 in reply to: ↑ 1 @olarmarius
3 years ago

Replying to ocean90:

Hello @olarmarius, thanks for your report. I don't fully understand the issue (yet). Looks like you forgot to upload the patch?

Sorry, I hurried and forgot

Note: See TracTickets for help on using tickets.