Context Navigation

← Previous Ticket
Next Ticket →

#37587 closed enhancement (duplicate)

Inconsistency on deleting plugin/theme on WP 4.6

Reported by:	olarmarius	Owned by:
Priority:	normal	Milestone:
Component:	Themes	Version:	4.4
Severity:	normal	Keywords:
Cc:		Focuses:	administration

Description

On delete plugin admin-ajax call see
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/ajax-actions.php#L3821

the actions delete_plugin see
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/plugin.php#L846

and deleted_plugin see
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/plugin.php#L865

are missing from theme deletion.

Please consider adding this patch in 4.6 as the realease is imminent and the patch is realy just for the sake of consistency.

Attachments (1)

wordpress.patch.ticket.37587.diff (1.1 KB ) - added by olarmarius 10 years ago.: Patch for 37587 ticket

Download all attachments as: .zip

Change History (6)

#1 follow-up: ↓ 4 @ocean90
10 years ago

Focuses performance removed
Keywords reporter-feedback added

Hello @olarmarius, thanks for your report. I don't fully understand the issue (yet). Looks like you forgot to upload the patch?

This ticket was mentioned in Slack in #core by mario. View the logs.

10 years ago

#3 @SergeyBiryukov
10 years ago

Component General → Themes
Type defect (bug) → enhancement
Version trunk → 4.4

Looks like the suggestion is to introduce delete_theme and deleted_theme actions.

delete_plugin and deleted_plugin were added in [35094] and [35669], so it's not a regression in 4.6.

@olarmarius
10 years ago

Attachment wordpress.patch.ticket.37587.diff added

Patch for 37587 ticket

#4 in reply to: ↑ 1 @olarmarius
10 years ago

Replying to ocean90:

Hello @olarmarius, thanks for your report. I don't fully understand the issue (yet). Looks like you forgot to upload the patch?

Sorry, I hurried and forgot

#5 @sabernhardt
4 years ago

Keywords reporter-feedback removed
Resolution → duplicate
Status new → closed

Duplicate of #16401.

Thanks for the ticket and the patch! The delete_theme and deleted_theme actions were added in r50826 (see ticket:16401).

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#37587 closed enhancement (duplicate)

Inconsistency on deleting plugin/theme on WP 4.6

Description

Attachments (1)

Change History (6)

#1 follow-up: ↓ 4 @ocean90 10 years ago

This ticket was mentioned in ​Slack in #core by mario. ​View the logs. 10 years ago

#3 @SergeyBiryukov 10 years ago

@olarmarius 10 years ago

#4 in reply to: ↑ 1 @olarmarius 10 years ago

#5 @sabernhardt 4 years ago