#37598 closed defect (bug) (fixed)
Fix plugin/theme delete/install success hook inconsistency
Reported by: | olarmarius | Owned by: | jorbin |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Themes | Keywords: | has-patch commit |
Focuses: | javascript, administration | Cc: |
Description
The delete hook name for plugin deletion is "wp-plugin-delete-success" and for theme "wp-delete-theme-success". We need to resolve this inconsistency.
A) wp-delete-plugin-success & wp-delete-theme-success
B) wp-plugin-delete-success & wp-theme-delete-success
wp-plugin-delete-success
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/updates.js?rev=38199&marks=821&1246#L819
wp-delete-theme-success
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/updates.js?rev=38199&marks=821&1246#L1246
Attachments (4)
Change History (14)
#2
follow-up:
↓ 3
@
8 years ago
- Component changed from Administration to Themes
- Keywords has-patch added
It should be B), see 37598.patch.
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
8 years ago
Replying to ocean90:
It should be A), see 37598.patch.
But it's A see https://core.trac.wordpress.org/attachment/ticket/37598/updates.js.37598.diff
#5
@
8 years ago
- Keywords commit added
- Summary changed from Fix plugin/theme delete success hook inconsistency to Fix plugin/theme delete/install success hook inconsistency
As pointed out by @olarmarius, the install actions are also inconsistent.
37598.2.patch combines 37598-install.patch and 37598.patch.
Introduced in [37714].