Missing visual feedback when deleting themes/plugins

[ocean90]

Only on wp-admin/themes.php the delete button changes to "Deleting…". Also, when I cancel the credential modal the button remains at "Deleting…".

• https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/updates.js?rev=38209&marks=716,726#L702 doesn't look right. .update-message has nothing to do with a delete link right?
• For themes we have https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/updates.js?rev=38209&marks=1168,1179#L1155 which doesn't work for themes-network

[swissspidy]

37603.diff​ removes the lines in questions from wp.updates.deletePlugin as they're indeed not needed and fixes the issue on themes.php

[ocean90]

37603.diff​ is not what I wanted: 1) Instead of removing the code we should make it work. 2) 'themes' === pagenow in the credential-modal-cancel callback is also true for a canceled update job, we have to check if it's a delete job.

[swissspidy]

Thanks for the clarification.

37603.3.diff​ actually changes the "Delete" link for plugins and properly distinguishes updates and deletions in the credential-modal-cancel callback.

[ocean90]

37603.4.diff​ renames $message to $link and changes

if ( 'update-theme' === job.action ) {
        $message = $( '[data-slug="' + job.data.slug + '"]' ).find( '.update-message' );
} else if ( 'delete-theme' === job.action ) {
        if ( 'themes-network' === pagenow ) {
                $message = $( '[data-slug="' + job.data.slug + '"]' ).find( '.row-actions a.delete' );
        } else {
                $message = $( '.theme-actions .delete-theme' );
        }
}

to

if ( 'update-theme' === job.action ) {
        $message = $( '[data-slug="' + job.data.slug + '"]' ).find( '.update-message' );
} else if ( 'delete-theme' === job.action && 'themes-network' === pagenow ) {
        $message = $( '[data-slug="' + job.data.slug + '"]' ).find( '.row-actions a.delete' );
} else if ( 'delete-theme' === job.action && 'themes' === pagenow ) {
        $message = $( '.theme-actions .delete-theme' );
}

which makes it more readable IMO.

[jorbin]

patch no longer applies clean after [38221].

New patch applies clean. @ocean90 Back to you.

[ocean90]

In 38227:

Updates: Add visual feedback when deleting themes/plugins.

This corrects the selector for the delete link in wp.updates.deletePlugin() so the text can be changed to 'Deleting…'. wp.updates.deleteTheme() already worked on wp-admin/themes.php but not on wp-admin/network/themes.php because the network screen is similar to the plugins list table, this is now fixed too.
The credential-modal-cancel handler has been updated to support canceled delete jobs.

Props swissspidy.
Props jorbin for review.
Fixes #37603.

[ocean90]

In 38228:

Updates: Add visual feedback when deleting themes/plugins.

This corrects the selector for the delete link in wp.updates.deletePlugin() so the text can be changed to 'Deleting…'. wp.updates.deleteTheme() already worked on wp-admin/themes.php but not on wp-admin/network/themes.php because the network screen is similar to the plugins list table, this is now fixed too.
The credential-modal-cancel handler has been updated to support canceled delete jobs.

Merge of [38227] to the 4.6 branch.

Props swissspidy.
Props jorbin for review.
See #37603.