Make WordPress Core

Opened 8 years ago

Closed 5 years ago

#37605 closed defect (bug) (wontfix)

Change `private` member access to `protected` in `MakePOT` class

Reported by: jdgrimes's profile jdgrimes Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:


In [36752] (i18n40327) visibility keywords were added to the properties and methods of the MakePOT class, which is bundled with trunk in tools/i18n/makepot.php. Mostly these were made public, however, some were not intended to be public (but previously were do to lack of any visibility restrictions) and so were made private. This will break any child class that might be attempting to use these properties/methods. It would be better if these were changed to protected, rather than private, especially considering that they were made freely public before. Otherwise code that expected the prior behavior not only breaks, but has no real work-around either (other than just copying those methods and properties to the child class, or continuing to use the legacy version).

(Discussion in #core channel on Slack prior to making this ticket.)

Change History (2)

#1 @ocean90
8 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to
  • Version trunk deleted

#2 @johnbillion
5 years ago

  • Milestone deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing due to lack of activity in three years.

Note: See TracTickets for help on using tickets.