WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 weeks ago

#37605 closed defect (bug) (wontfix)

Change `private` member access to `protected` in `MakePOT` class

Reported by: jdgrimes Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:

Description

In [36752] (i18n40327) visibility keywords were added to the properties and methods of the MakePOT class, which is bundled with trunk in tools/i18n/makepot.php. Mostly these were made public, however, some were not intended to be public (but previously were do to lack of any visibility restrictions) and so were made private. This will break any child class that might be attempting to use these properties/methods. It would be better if these were changed to protected, rather than private, especially considering that they were made freely public before. Otherwise code that expected the prior behavior not only breaks, but has no real work-around either (other than just copying those methods and properties to the child class, or continuing to use the legacy version).

(Discussion in #core channel on Slack prior to making this ticket.)

Change History (2)

#1 @ocean90
2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to WordPress.org
  • Version trunk deleted

#2 @iseulde
2 weeks ago

  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This ticket has not seen any activity in over *two* years, so I'm closing it as "wontfix".

The ticket may lack decisiveness, may have become irrelevant, or may not have gathered enough interest.

If you think this ticket does deserve some attention again, feel free to reopen.

For bugs, it would be great if you could provide updated steps to reproduce against the latest version of WordPress (5.0.2 at the time of writing). Remember images or a video can be superior to explain a problem. At the very least, quickly test again to make sure the bug still exists.

If it’s an enhancement or feature, some extra motivation may help.

Thank you for your contributions to WordPress! <3

Note: See TracTickets for help on using tickets.