WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 22 months ago

#37605 new defect (bug)

Change `private` member access to `protected` in `MakePOT` class

Reported by: jdgrimes Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:

Description

In [36752] (i18n40327) visibility keywords were added to the properties and methods of the MakePOT class, which is bundled with trunk in tools/i18n/makepot.php. Mostly these were made public, however, some were not intended to be public (but previously were do to lack of any visibility restrictions) and so were made private. This will break any child class that might be attempting to use these properties/methods. It would be better if these were changed to protected, rather than private, especially considering that they were made freely public before. Otherwise code that expected the prior behavior not only breaks, but has no real work-around either (other than just copying those methods and properties to the child class, or continuing to use the legacy version).

(Discussion in #core channel on Slack prior to making this ticket.)

Change History (1)

#1 @ocean90
22 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to WordPress.org
  • Version trunk deleted
Note: See TracTickets for help on using tickets.