WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37628 closed defect (bug) (fixed)

Wrong file name for WP_Automatic_Updater

Reported by: ocean90 Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.6
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:
PR Number:

Description

It's class-wp-automatic-upgrader.php but should be class-wp-automatic-updater.php.

Introduced in [37409].

Attachments (2)

37628.patch (1.0 KB) - added by ocean90 3 years ago.
37628.diff (131.5 KB) - added by DrewAPicture 3 years ago.

Download all attachments as: .zip

Change History (8)

@ocean90
3 years ago

#1 @ocean90
3 years ago

  • Keywords has-patch added
  • Owner set to ocean90
  • Status changed from new to accepted
  1. svn mv src/wp-admin/includes/class-wp-automatic-upgrader.php src/wp-admin/includes/class-wp-automatic-updater.php
  2. Apply 37628.patch

@DrewAPicture
3 years ago

#2 @DrewAPicture
3 years ago

@ocean90 37628.diff re-copies class-wp-upgrader.php at [37342] to class-wp-automatic-updater.php, the contents of which I then replaced with the contents of class-wp-automatic-upgrader.php and then deleted the latter.

The difference between this and 37628.patch is that we theoretically retain many of the blame records.

$ svn cp -r 37342 https://develop.svn.wordpress.org/trunk/src/wp-admin/includes/class-wp-upgrader.php src/wp-admin/includes/class-wp-automatic-updater.php
A         src/wp-admin/includes/class-wp-automatic-updater.php

Replaced -updater.php contents with current -upgrader.php code

$ svn rm src/wp-admin/includes/class-wp-automatic-upgrader.php 
D         src/wp-admin/includes/class-wp-automatic-upgrader.php
Version 0, edited 3 years ago by DrewAPicture (next)

This ticket was mentioned in Slack in #core by ocean90. View the logs.


3 years ago

#4 @DrewAPicture
3 years ago

@ocean90 In retrospect, doing the mv should retain the history as long as we don't move it to a different directory.

#5 @ocean90
3 years ago

In 38242:

Upgrader: Rename class-wp-automatic-upgrader.php to class-wp-automatic-updater.php.

The class is named WP_Automatic_Updater not WP_Automatic_Upgrader like all the other upgrader classes.

Introduced in [37409].
See #37628.

#6 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 38243:

Upgrader: Rename class-wp-automatic-upgrader.php to class-wp-automatic-updater.php.

The class is named WP_Automatic_Updater not WP_Automatic_Upgrader like all the other upgrader classes.

Introduced in [37409].

Merge of [38242] to the 4.6 branch.

Props DrewAPicture for review.
Fixes #37628.

Note: See TracTickets for help on using tickets.