is_sticky filter hook

[greenshady]

The is_sticky() function needs an accompanying filter hook.

This way, plugins that have custom post types with a custom sticky post implementation can simply filter this when necessary. This way, we don't have to roll a custom pluginslug_is_sticky() function every time.

[tdmalone]

How about the pre_option_sticky_posts filter?

There are other dynamic filters available in ​`get_option()` as well, which is_sticky() calls.

[greenshady]

Replying to tdmalone:

How about the pre_option_sticky_posts filter?

There are other dynamic filters available in ​`get_option()` as well, which is_sticky() calls.

By running a filter on that hook, you're filtering an option that's storing sticky posts of the post post type, not the result of the is_sticky() function. There's potential for some unintended consequences here when other code is calling get_option( 'sticky_posts' ).

While the option and the conditional are related by default, this is not necessarily true with custom sticky post implementations. Sticky posts can be stored in a variety of ways. A filter hook for the conditional function makes more sense in those scenarios.

[dehisok]

patch

[dehisok]

Changed conditions to prevent multiple apply_filters row. Made similar to the is_active_sidebar filter.
Enjoy :)
It's my the first contribution made at #WCEU

[SergeyBiryukov]

In 45671:

Posts, Post Types: Introduce is_sticky filter in is_sticky() to provide more flexibility for custom sticky post implementations.

Props dehisok, greenshady.
Fixes #37629.