Make WordPress Core

Opened 8 years ago

Closed 5 months ago

Last modified 5 months ago

#37647 closed enhancement (fixed)

FTP Credentials Modal should have a 'button-primary' class on the 'Proceed' button

Reported by: mapk's profile mapk Owned by: audrasjb's profile audrasjb
Milestone: 6.6 Priority: normal
Severity: normal Version: 4.6
Component: Administration Keywords: has-screenshots has-patch
Focuses: ui Cc:

Description

When reviewing another ticket's screenshots (#32194), I noticed that the 'Proceed' button in the FTP Credentials modal doesn't have the 'button-primary' class on it.

Existing view:
https://cldup.com/2dIi9fsIrd.png

Proposed view with 'button-primary' class
https://cldup.com/dr8Gu8K_sE.png

Attachments (5)

37674.patch (629 bytes) - added by curdin 8 years ago.
Capture d’écran 2024-04-23 à 23.37.45.png (152.8 KB) - added by audrasjb 6 months ago.
Before applying the PR
Capture d’écran 2024-04-23 à 23.40.57.png (159.4 KB) - added by audrasjb 6 months ago.
After applying the PR
37647-before-pr.png (84.6 KB) - added by shailu25 6 months ago.
Before PR.
37647-after-applying-pr.png (84.7 KB) - added by shailu25 6 months ago.
After Applying the PR

Download all attachments as: .zip

Change History (16)

#1 @mapk
8 years ago

  • Keywords has-screenshots added
  • Type changed from defect (bug) to enhancement

#2 @mapk
8 years ago

To trigger this modal, follow these steps below.

1) Add this to your wp-config.php: define( 'FS_METHOD', 'ftpext' );
2) Install an old version of a plugin
3) Browse to wp-admin/plugins.php
4) Click on the update now link in the plugin’s table row

@curdin
8 years ago

#4 @curdin
8 years ago

  • Keywords has-patch added

#5 @desrosj
5 years ago

  • Component changed from General to Administration
  • Keywords needs-refresh added
  • Milestone set to Future Release

@curdin are you able to refresh the patch against current trunk? I'm having issues applying the patch.

This ticket was mentioned in PR #6437 on WordPress/wordpress-develop by @audrasjb.


6 months ago
#6

  • Keywords needs-refresh removed

Testing steps:

1) Add this to your wp-config.php: define( 'FS_METHOD', 'ftpext' );
2) Install an old version of a plugin
3) Browse to wp-admin/plugins.php
4) Click on the update now link in the plugin’s table row

https://core.trac.wordpress.org/ticket/37647

#7 @audrasjb
6 months ago

  • Milestone changed from Future Release to 6.6

Hey there,

I refreshed the patch. Moving for 6.6 consideration.

@audrasjb
6 months ago

Before applying the PR

@audrasjb
6 months ago

After applying the PR

#8 @audrasjb
6 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#9 @shailu25
6 months ago

6437 Looks good to me. Its Adding primary class in the FTP Credentials Modal.

@shailu25
6 months ago

Before PR.

@shailu25
6 months ago

After Applying the PR

#10 @audrasjb
5 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 58149:

Administration: Add primary class to the FTP credentials modal submit button.

This helps differentiate the two buttons available in the FTP credentials modal by setting a primary class to the submit button.

Props mapk, curdin, audrasjb, shailu25.
Fixes #37647.

Note: See TracTickets for help on using tickets.