WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #37661, comment 71


Ignore:
Timestamp:
10/04/2016 05:22:43 PM (3 years ago)
Author:
folletto
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37661, comment 71

    initial v1  
    11I've added a potential alternative version, attached just above. This one should address all the concerns, both visual and accessibility wise, and it's compatible too with the keyboard/mouse navigation changes from #29158.
    22
    3 The only issue with that is that by the nature of the tool, we use the checkboxes in a slightly non-standard way: they would get unselected when they can't "play" together well (i.e. switching top-level ones) while they stay active when they do (inside Feature Filter). 
     3The only issue with that is that by the nature of the tool, we use the checkboxes in a slightly non-standard way: they would get unselected when they can't "play" together well (i.e. switching top-level ones) while they stay active when they do (inside Feature Filter).
    44
    55I think this is a slight change of the control (that's already happening behind the scenes, in practice) but it's an excellent compromise given how many other issues it solves.
     6Note also that the checkmark is triggered not just by clicking the small area, but as it is now, clicking anywhere on the box.
    67
    78Sorry for having proposed this this late.