Shiny Updates: Cancelling the filesystem credentials when updating within the pop-up prevents updating again (without closing/opening) and leaves UI artefacts

[DavidAnderson]

Reproducible on RC3: 4.6-RC3-38260

Reproducible: every time

Steps to reproduce:

1) Set up WordPress, and set permissions to that the 'filesystem credentials' dialog will be required when performing theme updates.

2) Tweak a version number so that you will have a theme that needs an update. Then, go to /wp-admin/themes.php

3) Do *not* click on the immediately visible "Update now". Instead, click on the theme such that the pop-up pops up.

4) Click on the "Update now" link within the pop-up. If step 1) was done correctly, then the filesystem dialog should now pop up.

5) Close the filesystem credentials dialog.

Result: "Updating..." will still show there. But nothing will be updating. You cannot update until you close the pop-up and re-open it.

Excepted result: The "update now" link re-appears, and "Updating.." disappears.

Result: nothing happens.

#37285 is similar, but a separate (and now fixed) issue.

[ocean90]

Confirmed, see 37669.gif​.

[fgiannar]

Hi there,

@desrosj This is an attempt to fix this issue. Please check it out and let me know accordingly.
Note that I checked out the corresponding qunit tests ( tests/qunit/wp-admin/js/updates.js ) but based on the existing content I was unsure if I needed to add a new one for this case.

Thanks,

[Laxman Prajapati]

Can you please try to add this line

define('FS_METHOD','direct');

In root wp-config.php file and after that try again please.

Thanks

[DavidAnderson]

This is not the place for support advice. The point is not to hide the bug on individual sites via not using the affected feature, it's to fix it.