WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 months ago

#37669 new defect (bug)

Shiny Updates: Cancelling the filesystem credentials when updating within the pop-up prevents updating again (without closing/opening) and leaves UI artefacts

Reported by: DavidAnderson Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.6
Component: Themes Keywords: good-first-bug has-patch
Focuses: javascript, administration Cc:

Description (last modified by ocean90)

Reproducible on RC3: 4.6-RC3-38260

Reproducible: every time

Steps to reproduce:

1) Set up WordPress, and set permissions to that the 'filesystem credentials' dialog will be required when performing theme updates.

2) Tweak a version number so that you will have a theme that needs an update. Then, go to /wp-admin/themes.php

3) Do *not* click on the immediately visible "Update now". Instead, click on the theme such that the pop-up pops up.

4) Click on the "Update now" link within the pop-up. If step 1) was done correctly, then the filesystem dialog should now pop up.

5) Close the filesystem credentials dialog.

Result: "Updating..." will still show there. But nothing will be updating. You cannot update until you close the pop-up and re-open it.

Excepted result: The "update now" link re-appears, and "Updating.." disappears.

Result: nothing happens.

#37285 is similar, but a separate (and now fixed) issue.

Attachments (3)

37669.gif (721.6 KB) - added by ocean90 4 years ago.
37669.diff (3.5 KB) - added by fgiannar 3 months ago.
37669.2.diff (3.5 KB) - added by fgiannar 3 months ago.

Download all attachments as: .zip

Change History (9)

@ocean90
4 years ago

#1 @ocean90
4 years ago

  • Component changed from Upgrade/Install to Themes
  • Description modified (diff)
  • Focuses administration added
  • Keywords needs-patch added
  • Summary changed from Shiny updates bug (WP 4.6 RC 3): Cancelling the filesystem credentials when updating within the pop-up prevents updating again (without closing/opening) and leaves UI artefacts to Shiny Updates: Cancelling the filesystem credentials when updating within the pop-up prevents updating again (without closing/opening) and leaves UI artefacts

Confirmed, see 37669.gif.

This ticket was mentioned in Slack in #core by ocean90. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by ocean90. View the logs.


4 years ago

#4 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @desrosj
4 months ago

  • Keywords good-first-bug added
  • Milestone set to Future Release

@fgiannar
3 months ago

#6 @fgiannar
3 months ago

  • Keywords has-patch added; needs-patch removed

Hi there,

@desrosj This is an attempt to fix this issue. Please check it out and let me know accordingly.
Note that I checked out the corresponding qunit tests ( tests/qunit/wp-admin/js/updates.js ) but based on the existing content I was unsure if I needed to add a new one for this case.

Thanks,

@fgiannar
3 months ago

Note: See TracTickets for help on using tickets.