WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 weeks ago

Last modified 9 days ago

#37675 closed enhancement (fixed)

Update Masonry (v4.1.0) & imagesLoaded (v4.1.0) package

Reported by: grapplerulrich Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 4.6
Component: External Libraries Keywords: has-dev-note
Focuses: javascript Cc:

Description

As this updates drops IE8 and 9 support we cannot update directly to these versions. We can't make the same switch from jquery-masonry to masonry as we don't have a shiv and which is a bit counterproductive if IE 8 & 9 support has been dropped.

I think it would be good to think for the future as I expect version v5 will also be a breaking change.

Possible solutions:

  • Register a new handle masonry-4
  • Deprecate Masonry from core. jquery-masonry is used for the custom-header script, Twenty Thirteen and Twenty Fourteen.
  • Add an option to wp_enqueue_script to define which version of script that is needed. We can include v3.x and v4.x and the developer can define which version that they need.

Masonry

imagesloaded

Change History (9)

#1 @pderksen
3 years ago

+1 the idea of registering new handles such as masonry-4& imagesloaded-4.

We're using imagesLoaded 4.x in Simple Calendar, which is a dependency of qTip2 (also used in the plugin and by the same author).

Should we also have the unminified versions of these libs (old and new versions) included for debugging purposes (and to follow suit with other JS libs)?

#2 @SergeyBiryukov
8 months ago

#48548 was marked as a duplicate.

#3 @SergeyBiryukov
8 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.4

As this updates drops IE8 and 9 support we cannot update directly to these versions.

Per https://make.wordpress.org/core/handbook/best-practices/browser-support/, the support for these IE versions is already dropped, so this should no longer be a limitation in updating.

#4 @davidbaumwald
5 months ago

  • Milestone changed from 5.4 to Future Release

With 5.4 Beta 1 approaching and no recent movement on this ticket, it's being moved to Future Release. If any maintainer or committer feels this can be patched and tested in time, or can assume ownership during a specific cycle, feel free to update the milestone accordingly.

#6 @SergeyBiryukov
4 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48038:

External Libraries: Update Masonry to 4.2.2 and imagesLoaded to 4.1.4.

Notable changes include dropping support for IE 8 & 9, which are no longer supported by WordPress core either.

Release notes:
https://github.com/desandro/masonry/releases
https://github.com/desandro/imagesloaded/releases

Changelogs:
https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2
https://github.com/desandro/imagesloaded/compare/v3.2.0...v4.1.4

Props pierlo, hareesh-pillai, grapplerulrich, pderksen, desrosj, garrett-eclipse, SergeyBiryukov.
Fixes #37675, #48031.

#7 @SergeyBiryukov
4 weeks ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 5.5

#8 @desrosj
2 weeks ago

  • Keywords needs-dev-note added

#9 @desrosj
9 days ago

  • Keywords has-dev-note added; needs-dev-note removed
Note: See TracTickets for help on using tickets.