#37675 closed enhancement (fixed)
Update Masonry (v4.1.0) & imagesLoaded (v4.1.0) package
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | External Libraries | Keywords: | has-dev-note |
Focuses: | javascript | Cc: |
Description
As this updates drops IE8 and 9 support we cannot update directly to these versions. We can't make the same switch from jquery-masonry
to masonry
as we don't have a shiv and which is a bit counterproductive if IE 8 & 9 support has been dropped.
I think it would be good to think for the future as I expect version v5 will also be a breaking change.
Possible solutions:
- Register a new handle
masonry-4
- Deprecate Masonry from core.
jquery-masonry
is used for the custom-header script, Twenty Thirteen and Twenty Fourteen. - Add an option to
wp_enqueue_script
to define which version of script that is needed. We can include v3.x and v4.x and the developer can define which version that they need.
Masonry
- v4.0.0 removes IE8 & 9 support: https://github.com/desandro/masonry/releases/tag/v4.0.0
- v4.1.0 - stagger option: https://github.com/desandro/masonry/releases/tag/v4.1.0
imagesloaded
- v4.0.0 - remove IE8 support: https://github.com/desandro/imagesloaded/releases/tag/v4.0.0
- v4.1.0 - ev-emitter: https://github.com/desandro/imagesloaded/releases/tag/v4.1.0
Change History (9)
#3
@
5 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 5.4
As this updates drops IE8 and 9 support we cannot update directly to these versions.
Per https://make.wordpress.org/core/handbook/best-practices/browser-support/, the support for these IE versions is already dropped, so this should no longer be a limitation in updating.
#4
@
5 years ago
- Milestone changed from 5.4 to Future Release
With 5.4 Beta 1 approaching and no recent movement on this ticket, it's being moved to Future Release
. If any maintainer or committer feels this can be patched and tested in time, or can assume ownership during a specific cycle, feel free to update the milestone accordingly.
#6
@
5 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 48038:
#9
@
5 years ago
- Keywords has-dev-note added; needs-dev-note removed
This was noted in the following dev note: https://make.wordpress.org/core/2020/07/01/external-library-updates-in-wordpress-5-5-call-for-testing/
+1 the idea of registering new handles such as
masonry-4
&imagesloaded-4
.We're using imagesLoaded 4.x in Simple Calendar, which is a dependency of qTip2 (also used in the plugin and by the same author).
Should we also have the unminified versions of these libs (old and new versions) included for debugging purposes (and to follow suit with other JS libs)?