WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 7 years ago

#37710 closed enhancement (wontfix)

Allow fullscreen for ThickBox

Reported by: neoxx Owned by:
Priority: normal Milestone:
Component: External Libraries Version:
Severity: normal Keywords: has-patch
Cc: Focuses: ui, javascript

Description

I use ThickBox to display YouTube and Flickr videos in an overlay. - Though, YouTube and Flickr both support fullscreen display, the necessary attribute is not set in ThickBox's iframe implementation.

Attached patch - which should not have any adverse effects - fixes this.

Attachments (1)

37710.patch​ (2.3 KB ) - added by neoxx 10 years ago.

Download all attachments as: .zip

Change History (4)

@neoxx
10 years ago

#1 @neoxx
10 years ago

  • Keywords has-patch added

#2 @swissspidy
10 years ago

  • Version 4.7

#3 @desrosj
7 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

Hi @neoxx,

Thanks for this suggestion. My apologies that it took so long to receive a response.

The Thickbox library is quite old and unmaintained. I don't think this is something that should be added to WordPress Core. In fact, removing Thickbox from Core has come up in several discussions over the last year. I have created #46985 so that discussion can take place.

With those things in mind, I am going to close this out as a wontfix, but if there is more demand for this feature this can be reopened and re-evaluated.

Note: See TracTickets for help on using tickets.