WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#37720 closed defect (bug) (fixed)

The minified version of the masonry shim was not upded in #37666

Reported by: stephenharris Owned by: jorbin
Milestone: 4.6.1 Priority: normal
Severity: normal Version: 4.6
Component: External Libraries Keywords: fixed-major has-patch
Focuses: Cc:

Description

#37666 fixed a bug with jquery-masonry, but the minified version was not updated.

Change History (7)

#1 @swissspidy
2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.6.1

#2 @jorbin
2 years ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 38276:

External Libraries: Update Minified version of jquery.masonry.js

WordPress maintains the minified version of jquery.masonry.js since there is no official build, however it has been excluded from grunt's minification process. This adds a minification task to grunt, adds it to the precommit hook for JS, minifies the file, and bumps the version on jquery.masonry.min.js. The change to the non minified version was introduced in [38261].

Fixes #37720. See #37666.

#3 @jorbin
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for consideration of merge to 4.6.1

#4 @jorbin
2 years ago

In 38281:

Fix jshint of Gruntfile.js

Introduced in [38276]

See #37720.

#5 @swissspidy
2 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


2 years ago

#7 @swissspidy
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 38339:

External Libraries: Update minified version of jquery.masonry.js.

WordPress maintains the minified version of jquery.masonry.js since there is no official build, however it has been excluded from grunt's minification process. This adds a minification task to grunt, adds it to the precommit hook for JS, minifies the file, and bumps the version on jquery.masonry.min.js. The change to the non minified version was introduced in [38261].

Merge of [38276] and [38281] to the 4.6 branch.

Fixes #37720. See #37666.

Note: See TracTickets for help on using tickets.