WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 2 weeks ago

#37750 assigned defect (bug)

Cropping custom logo should preserve attachment properties

Reported by: flixos90 Owned by: joemcgill
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.5
Component: Media Keywords: needs-patch
Focuses: accessibility Cc:

Description

I just noticed that, when uploading and cropping a custom logo, the original attachment's properties won't be migrated to the cropped image. I specifically added an "alt" description of the image, but on the website it only showed the file name for the alt tag, since the new cropped image does not preserve any of the data provided into the uploaded image. I think this is unexpected behavior and should be fixed.

I think the data manually changed by the user should be migrated to the cropped image to prevent this.

Change History (11)

#1 @Clorith
13 months ago

  • Component changed from Themes to Media

I'm not sure I agree (just to give a counterpoint), if I manually crop an image, it is to put emphasis on a part of it, making it no longer relevant to the meta data added to the full image.

Scenario:

  • I upload a picture of a bunch of football players, I give it an alt label of "The whole football team in action"
  • I crop the image, I only want the part of the image where a player kicks the ball, I now have "Player McGee in action", as such it's expected that a new Alt title be put in, if we auto-populate the field then this will just be ignored.

I think a much better approach would be if the cropping tool actually provided the meta sidebar like the other media management windows does.
This would allow the meta data to be manipulated there and then, without running the risk of being forgotten or ignored, thoughts?

#2 @flixos90
13 months ago

Good point. Maybe a combination of both would do it. I think we should cover both scenarios - both of our proposals will ignore either one or the other. In my opinion a good solution would be to show the meta sidebar on the cropped image like you said, but fill in the values the user entered for the original image (as defaults). Many times these will apply to the cropped image as well, and if not, they could easily change it.

#3 @afercia
5 months ago

  • Focuses accessibility added

Related: #38768

This ticket was mentioned in Slack in #core by sami.keijonen. View the logs.


4 months ago

#5 @afercia
4 months ago

  • Milestone changed from Awaiting Review to 4.8.1
  • Owner set to afercia
  • Status changed from new to assigned

#6 @afercia
4 months ago

#36868 was marked as a duplicate.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 months ago

#8 @afercia
3 months ago

  • Milestone changed from 4.8.1 to 4.9

See also #30155

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-media by afercia. View the logs.


2 weeks ago

#11 @afercia
2 weeks ago

  • Owner changed from afercia to joemcgill

Agreed to re-assign ownership.

Note: See TracTickets for help on using tickets.