WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 10 months ago

#37750 assigned defect (bug)

Cropping custom logo should preserve attachment properties

Reported by: flixos90 Owned by: joemcgill
Milestone: Future Release Priority: normal
Severity: normal Version: 4.5
Component: Media Keywords: needs-patch
Focuses: accessibility Cc:
PR Number:

Description

I just noticed that, when uploading and cropping a custom logo, the original attachment's properties won't be migrated to the cropped image. I specifically added an "alt" description of the image, but on the website it only showed the file name for the alt tag, since the new cropped image does not preserve any of the data provided into the uploaded image. I think this is unexpected behavior and should be fixed.

I think the data manually changed by the user should be migrated to the cropped image to prevent this.

Change History (21)

#1 @Clorith
3 years ago

  • Component changed from Themes to Media

I'm not sure I agree (just to give a counterpoint), if I manually crop an image, it is to put emphasis on a part of it, making it no longer relevant to the meta data added to the full image.

Scenario:

  • I upload a picture of a bunch of football players, I give it an alt label of "The whole football team in action"
  • I crop the image, I only want the part of the image where a player kicks the ball, I now have "Player McGee in action", as such it's expected that a new Alt title be put in, if we auto-populate the field then this will just be ignored.

I think a much better approach would be if the cropping tool actually provided the meta sidebar like the other media management windows does.
This would allow the meta data to be manipulated there and then, without running the risk of being forgotten or ignored, thoughts?

#2 @flixos90
3 years ago

Good point. Maybe a combination of both would do it. I think we should cover both scenarios - both of our proposals will ignore either one or the other. In my opinion a good solution would be to show the meta sidebar on the cropped image like you said, but fill in the values the user entered for the original image (as defaults). Many times these will apply to the cropped image as well, and if not, they could easily change it.

#3 @afercia
3 years ago

  • Focuses accessibility added

Related: #38768

This ticket was mentioned in Slack in #core by sami.keijonen. View the logs.


3 years ago

#5 @afercia
3 years ago

  • Milestone changed from Awaiting Review to 4.8.1
  • Owner set to afercia
  • Status changed from new to assigned

#6 @afercia
3 years ago

#36868 was marked as a duplicate.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#8 @afercia
2 years ago

  • Milestone changed from 4.8.1 to 4.9

See also #30155

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

This ticket was mentioned in Slack in #core-media by afercia. View the logs.


2 years ago

#11 @afercia
2 years ago

  • Owner changed from afercia to joemcgill

Agreed to re-assign ownership.

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


2 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


2 years ago

#15 @melchoyce
2 years ago

  • Milestone changed from 4.9 to 4.9.1

#16 @johnbillion
2 years ago

  • Milestone changed from 4.9.1 to 5.0

#17 @flixos90
14 months ago

  • Milestone changed from 5.0 to 5.1

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


11 months ago

#19 @pento
11 months ago

  • Milestone changed from 5.1 to Future Release

#20 @dlh
10 months ago

#46185 was marked as a duplicate.

#21 @jarledb
10 months ago

Why is this being ignored? It is an actual accessibility issue - since it takes away the ability to set proper alt text on the site logo.

Its also a very frustrating bug to come across when trying to set alt text for the site image (when its been cropped).

The very least it should be documented in the WordPress Codex so people can find it and understand that alt text (and other attachment data) is not available for the image after being cropped in the customizer.

Note: See TracTickets for help on using tickets.