WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 4 months ago

#37760 closed defect (bug) (fixed)

problem with RTL

Reported by: saeed205 Owned by: azaozz
Milestone: 4.6.1 Priority: normal
Severity: normal Version: 4.6
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description (last modified by azaozz)

Hello,
Persian is my WordPress Language (RTL). The TinyMCE toolbars will not display properly on my site. They are on the left.

I did not have this problem in version 4.5.
http://up.persianscript.ir/uploadsmedia/4e8f-Capture.png

Attachments (3)

4e8f-Capture.png (16.7 KB) - added by saeed205 3 years ago.
37760.patch (1.1 KB) - added by azaozz 3 years ago.
37760.1.patch (2.4 KB) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (22)

@saeed205
3 years ago

#1 @azaozz
3 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 4.6.1

#2 @azaozz
3 years ago

Confirmed. Working on a patch.

@azaozz
3 years ago

#3 @azaozz
3 years ago

This is going to be fixed upstream, and a new TinyMCE version is expected next week.

37760.patch fixes it in trunk and 4.6. I'm a bit "uneasy" about including a TinyMCE update in a dot release and auto-updating to it. Perhaps better to use the patch for 4.6.1.

#4 @azaozz
3 years ago

  • Keywords has-patch needs-testing added

Some more testing especially in RTL languages would be great (note that RTL cannot be tested when running from /src).

#5 @swissspidy
3 years ago

Successfully tested it using the RTL Tester plugin with /build.

I think we've done TinyMCE updates in minor releases in the past, but better be safe than sorry.

#6 follow-up: @jeremyfelt
3 years ago

FWIW, here are the current changes for the next minor TinyMCE release - https://github.com/tinymce/tinymce/compare/4.4.1...master and those related to the RTL issue - https://github.com/tinymce/tinymce/compare/efc7af2...a953d0f

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


3 years ago

#8 @jeremyfelt
3 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

@azaozz I'm adding you as the owner. Feel free to toss it back to me. :)

#9 in reply to: ↑ 6 @azaozz
3 years ago

Replying to swissspidy:

Thanks for testing.

I think we've done TinyMCE updates in minor releases in the past, but better be safe than sorry.

Right. We've done that in the past when the had to push TinyMCE fixes. In this case we can fix it by setting RTL a bit earlier before initializing the editor instance without updating the whole TinyMCE.

Replying to jeremyfelt:

FWIW, here are the current changes for the next minor TinyMCE release

There are few things in there that would be better to be tested more, probably the largest one is rewrite of cE=false drag/drop logic.

I'm adding you as the owner.

Thanks, that's fine.

Last edited 3 years ago by azaozz (previous) (diff)

@azaozz
3 years ago

#10 @azaozz
3 years ago

In 37760.1.patch: also set the new rtl_ui option for RTL languages.

#11 @saeed205
3 years ago

Thank you
But I do not know how I test the patch.

#12 @swissspidy
3 years ago

#37809 was marked as a duplicate.

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


3 years ago

#14 @azaozz
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38349:

TinyMCE: fix toolbars alignment in RTL.

Fixes #37760 for trunk.

#15 @azaozz
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.6.1.

Committed to trunk to make it a bit easier to test.

@saeed205 best way to test this is by running a test install of the current nightly build (4.7-alpha), or you can paste the changes from class-wp-editor.php file (from [38349]) to the same file in your install.

Last edited 3 years ago by azaozz (previous) (diff)

#16 @geminorum
3 years ago

solved in 4.7-alpha-38392

#17 @jeremyfelt
3 years ago

  • Keywords needs-testing removed

[38349] looks good and resolves the issue in my testing. Merging to the 4.6 branch to prep for RC.

#18 @jeremyfelt
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 38488:

TinyMCE: fix toolbars alignment in RTL.

Merge of [38349] to the 4.6 branch.

Props azaozz, geminorum for testing.
Fixes #37760.

#19 @ocean90
3 years ago

Follow-up: #38000

Note: See TracTickets for help on using tickets.