problem with RTL

[saeed205]

Hello,
Persian is my WordPress Language (RTL). The TinyMCE toolbars will not display properly on my site. They are on the left.

I did not have this problem in version 4.5.
​http://up.persianscript.ir/uploadsmedia/4e8f-Capture.png

[azaozz]

Confirmed. Working on a patch.

[azaozz]

This is going to be fixed upstream, and a new TinyMCE version is expected next week.

37760.patch fixes it in trunk and 4.6. I'm a bit "uneasy" about including a TinyMCE update in a dot release and auto-updating to it. Perhaps better to use the patch for 4.6.1.

[azaozz]

Some more testing especially in RTL languages would be great (note that RTL cannot be tested when running from /src).

[swissspidy]

Successfully tested it using the RTL Tester plugin with /build.

I think we've done TinyMCE updates in minor releases in the past, but better be safe than sorry.

[jeremyfelt]

FWIW, here are the current changes for the next minor TinyMCE release - ​https://github.com/tinymce/tinymce/compare/4.4.1...master and those related to the RTL issue - ​https://github.com/tinymce/tinymce/compare/efc7af2...a953d0f

[jeremyfelt]

@azaozz I'm adding you as the owner. Feel free to toss it back to me. :)

[azaozz]

Replying to swissspidy:

Thanks for testing.

I think we've done TinyMCE updates in minor releases in the past, but better be safe than sorry.

Right. We've done that in the past when the had to push TinyMCE fixes. In this case we can fix it by setting RTL a bit earlier before initializing the editor instance without updating the whole TinyMCE.

Replying to jeremyfelt:

FWIW, here are the current changes for the next minor TinyMCE release

There are few things in there that would be better to be tested more, probably the largest one is ​rewrite of cE=false drag/drop logic.

I'm adding you as the owner.

Thanks, that's fine.

[azaozz]

In 37760.1.patch: also set the new rtl_ui option for RTL languages.

[saeed205]

Thank you
But I do not know how I test the patch.

[swissspidy]

#37809 was marked as a duplicate.

[azaozz]

In 38349:

TinyMCE: fix toolbars alignment in RTL.

Fixes #37760 for trunk.

[azaozz]

Reopen for 4.6.1.

Committed to trunk to make it a bit easier to test.

@saeed205 best way to test this is by running a test install of the current nightly build (4.7-alpha), or you can paste the changes from class-wp-editor.php file (from [38349]) to the same file in your install.

[geminorum]

solved in 4.7-alpha-38392

[jeremyfelt]

[38349] looks good and resolves the issue in my testing. Merging to the 4.6 branch to prep for RC.

[jeremyfelt]

In 38488:

TinyMCE: fix toolbars alignment in RTL.

Merge of [38349] to the 4.6 branch.

Props azaozz, geminorum for testing.
Fixes #37760.

[ocean90]

Follow-up: #38000