#37760 closed defect (bug) (fixed)
problem with RTL
Reported by: | saeed205 | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.6.1 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | TinyMCE | Keywords: | has-patch |
Focuses: | Cc: |
Description (last modified by )
Hello,
Persian is my WordPress Language (RTL). The TinyMCE toolbars will not display properly on my site. They are on the left.
I did not have this problem in version 4.5.
http://up.persianscript.ir/uploadsmedia/4e8f-Capture.png
Attachments (3)
Change History (22)
#3
@
8 years ago
This is going to be fixed upstream, and a new TinyMCE version is expected next week.
37760.patch fixes it in trunk and 4.6. I'm a bit "uneasy" about including a TinyMCE update in a dot release and auto-updating to it. Perhaps better to use the patch for 4.6.1.
#4
@
8 years ago
- Keywords has-patch needs-testing added
Some more testing especially in RTL languages would be great (note that RTL cannot be tested when running from /src).
#5
@
8 years ago
Successfully tested it using the RTL Tester plugin with /build.
I think we've done TinyMCE updates in minor releases in the past, but better be safe than sorry.
#6
follow-up:
↓ 9
@
8 years ago
FWIW, here are the current changes for the next minor TinyMCE release - https://github.com/tinymce/tinymce/compare/4.4.1...master and those related to the RTL issue - https://github.com/tinymce/tinymce/compare/efc7af2...a953d0f
This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.
8 years ago
#8
@
8 years ago
- Owner set to azaozz
- Status changed from new to assigned
@azaozz I'm adding you as the owner. Feel free to toss it back to me. :)
#9
in reply to:
↑ 6
@
8 years ago
Replying to swissspidy:
Thanks for testing.
I think we've done TinyMCE updates in minor releases in the past, but better be safe than sorry.
Right. We've done that in the past when the had to push TinyMCE fixes. In this case we can fix it by setting RTL a bit earlier before initializing the editor instance without updating the whole TinyMCE.
Replying to jeremyfelt:
FWIW, here are the current changes for the next minor TinyMCE release
There are few things in there that would be better to be tested more, probably the largest one is rewrite of cE=false drag/drop logic.
I'm adding you as the owner.
Thanks, that's fine.
This ticket was mentioned in Slack in #core by swissspidy. View the logs.
8 years ago
#15
@
8 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopen for 4.6.1.
Committed to trunk to make it a bit easier to test.
@saeed205 best way to test this is by running the current nightly build (4.7-alpha), or you can paste the changes from class-wp-editor.php file (from [38349]) to the same file in your install.
Confirmed. Working on a patch.