WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37771 closed defect (bug) (fixed)

Scrutinizer in 4.7

Reported by: wonderboymusic Owned by: wonderboymusic
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Remove unused code, etc. It has been a long time since I have run these scans.

Change History (17)

#1 @wonderboymusic
3 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned

#2 @wonderboymusic
3 years ago

In 38308:

General: remove variable set needlessly in wp_check_jsonp_callback().

See #37771.

#3 @wonderboymusic
3 years ago

In 38309:

Media: remove unnecessary variable assignment in gallery_shortcode().

See #37771.

#4 @wonderboymusic
3 years ago

In 38310:

REST API: remove unnecessary variable assignments in rest_handle_options_request().

See #37771.

#5 @wonderboymusic
3 years ago

In 38311:

Nav Menus: remove unnecessary variable assignment in wp_nav_menu_item_post_type_meta_box().

See #37771.

#6 @wonderboymusic
3 years ago

In 38312:

Taxonomy: remove unnecessary break in WP_Term::__get().

See #37771.

#7 @wonderboymusic
3 years ago

In 38313:

Comments: in wp_handle_comment_submission(), $_wp_unfiltered_html_comment is passed as part of $comment_data, but is not used locally.

See #37771.

#8 @wonderboymusic
3 years ago

In 38314:

Database: WP_Network, WP_Network_Query, and WP_Site_Query call wpdb::_escape(), thus requiring it to be public. It previously had no access modifier. _ at the beginning of a method, believe it or not, does not enforce visibility constraints.

See #37771.

#9 @wonderboymusic
3 years ago

In 38315:

HTTP: in WP_HTTP_Response, the @param declarations for $status and $headers were swapped. Let us correct this.

See #37771.

#10 @wonderboymusic
3 years ago

In 38316:

Locale: declare the $month_genitive field on WP_Locale.

See #37771.

#11 @wonderboymusic
3 years ago

In 38317:

Users: $user_level has been publicly-accessed on instances of WP_User since version 2.0, but is has never been declared.

See #37771.

#12 @wonderboymusic
3 years ago

In 38318:

Widgets: $option_name and $alt_option_name have been used as members ever since WP_Widget became an object in 2.8, but never declared.

See #37771.

#13 @wonderboymusic
3 years ago

In 38319:

Users: after [38317], use a @property annotation, instead of a public field.

See #37771.

#14 @jorbin
3 years ago

@wonderboymusic is there more that you plan to do here for 4.7, or can this be closed out?

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#17 @helen
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

No further movement, closing as fixed.

Note: See TracTickets for help on using tickets.