WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#37777 closed defect (bug) (fixed)

Replace _x() with __() and translators comments in wp-admin/includes/network.php

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Context function _x() is used to differ two similar strings with different meanings. Translators comments are used to describe %s placeholders.

The attached patch is replacing:

_x( '%s Sites', 'Default network name' )

with:

/* translators: %s: Default network name */
__( '%s Sites' )

Attachments (2)

37777.patch​ (922 bytes) - added by ramiy 9 years ago.
37777.png​ (36.6 KB) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (5)

@ramiy
9 years ago

@ramiy
9 years ago

#1 @ramiy
9 years ago

  • Keywords has-patch added

Related: #37496

#2 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 4.7

#3 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 38323:

I18N: Replace unnecessary context with a translator comment for %s Sites string in network_step1().

Props ramiy.
Fixes #37777.

Note: See TracTickets for help on using tickets.