WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37778 closed defect (bug) (fixed)

Replace _x() with __() to merge similar translation strings wp-includes/post-template.php

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Context function _x() is used to differ two similar strings with different meanings.

This patch is replacing the context _x() function with regular __() function to merge those strings. And avoid wrong usage of context functions.

Those are similar translation strings. They should be merged. The only difference is the %s placeholder. We document this difference in translators comments, not as a context.

See the attached screenshot from translate.wordpress.org and the attached patch.

Attachments (2)

37778.png (33.0 KB) - added by ramiy 3 years ago.
37778.patch (1.3 KB) - added by ramiy 3 years ago.

Download all attachments as: .zip

Change History (5)

@ramiy
3 years ago

@ramiy
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.7

#2 @ramiy
3 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 38324:

I18N: Replace unnecessary context with translator comments in wp_post_revision_title() and wp_post_revision_title_expanded().

Props ramiy.
Fixes #37778.

Note: See TracTickets for help on using tickets.