Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#37781 closed defect (bug) (fixed)

Replace _x() with __() and translators comments in wp-includes/post-template.php

Reported by: ramiy Owned by: SergeyBiryukov
Priority: normal Milestone: 4.7
Component: I18N Version:
Severity: normal Keywords:
Cc: Focuses:

Description

Context function _x() is used to differ two similar strings with different meanings. Translators comments are used to describe %s placeholders.

The attached patch is replacing:

/* translators: post revision title: 1: author avatar, 2: author name, 3: time ago, 4: date */
_x( '%1$s %2$s, %3$s ago (%4$s)', 'post revision title' )

With:

/* translators: post revision title: 1: author avatar, 2: author name, 3: time ago, 4: date */
__( '%1$s %2$s, %3$s ago (%4$s)' )

Attachments (3)

37781.png​ (43.4 KB ) - added by ramiy 10 years ago.
37781b.png​ (60.2 KB ) - added by ramiy 10 years ago.
37781.patch​ (584 bytes ) - added by ramiy 10 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
10 years ago

@ramiy
10 years ago

@ramiy
10 years ago

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.


10 years ago

#2 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 38327:

I18N: Remove unnecessary context in wp_post_revision_title_expanded().

Props ramiy.
Fixes #37781.

#3 @SergeyBiryukov
10 years ago

  • Milestone Awaiting Review → 4.7
Note: See TracTickets for help on using tickets.