XHTML validation problem with default theme

[pishmishy]

The default/kubrick Wordpress them doesn't validate as XHTML on some pages - it'd be nice if it did. The problem is caused by an empty list on the home page of your blog, where a notice would normally appear to inform you that you were browsing the archives. The problem code is between lines 14 and 39 of sidebar.php.

Replacing line 14 with:

<?php /* if any of these */ if
                        (
                                is_404()||
                                is_category()||
                                is_day()||
                                is_month()||
                                is_year()||
                                is_search()||
                                (
                                        isset($_GET['paged']) &&
                                        !empty($_GET['paged'])
                                )
                        )
                                { ?>
                        <li>
                        <?php }

?>

and line 39 with

                  <?php /* if any of these */ if
                        (
                                is_404()||
                                is_category()||
                                is_day()||
                                is_month()||
                                is_year()||
                                is_search()||
                                (
                                        isset($_GET['paged']) &&
                                        !empty($_GET['paged'])
                                )
                        )
                        { ?>
                        </li>
                        <?php } ?>

Appears to fix the problem. Is this a bug in wordpress or do I need to contact the theme's author?

James

[Viper007Bond]

WordPress bug as the theme is now managed by WordPress and not the original author.

[pishmishy]

I've created a patch to correct this issue.

[ryan]

Instead of doing the if twice, perhaps do it once and wrap it around that entire sidebar block.

[pishmishy]

corrected patch

[pishmishy]

Patch adjusted as suggested, with a slight bug fix (must close a list with </li>!)

[ryan]

(In [5127]) Don't output empty list. Props pishmishy. fixes #3779