WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#37822 new defect (bug)

Text area misaligned on network setting.php

Reported by: Ankit K Gupta Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.6
Component: Networks and Sites Keywords: has-screenshots needs-refresh
Focuses: ui, administration, multisite Cc:

Description

On Network setting page, all text area looks misaligned. Looks zig zag
Refer attached screenshots for better view.

Attachments (5)

Before-patch.png (145.8 KB) - added by Ankit K Gupta 4 years ago.
After patch.png (147.1 KB) - added by Ankit K Gupta 4 years ago.
37822.patch (333 bytes) - added by Ankit K Gupta 4 years ago.
added patch
Network_Settings_‹_Network_Admin_Core_Ankit_WP_Sites_—_WordPress_-_2016-10-20_19.49.13.png (109.6 KB) - added by Ankit K Gupta 4 years ago.
Screenshot In Firefox
Network_Settings_‹_Network_Admin_Core_Ankit_WP_Sites_—_In Chrome.png (68.8 KB) - added by Ankit K Gupta 4 years ago.
Screenshot In Chrome

Download all attachments as: .zip

Change History (22)

@Ankit K Gupta
4 years ago

added patch

#1 @Ankit K Gupta
4 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Networks and Sites
  • Focuses multisite added
  • Milestone changed from Awaiting Review to 4.7

#3 @jorbin
4 years ago

  • Keywords ui-feedback has-screenshots added

This ticket was mentioned in Slack in #design by jorbin. View the logs.


4 years ago

#5 follow-up: @karmatosed
4 years ago

  • Keywords commit added; ui-feedback removed

Thanks for screenshots, this certainly looks better @Ankit K Gupta. Have you tested on all devices to be sure?

@melchoyce, this seems like a good candidate to get committed in. Could you see what you think please?

Last edited 4 years ago by karmatosed (previous) (diff)

#6 in reply to: ↑ 5 @melchoyce
4 years ago

Replying to karmatosed:

Thanks for screenshots, this certainly looks better @Ankit K Gupta. Have you tested on all devices to be sure?

@melchoyce, this seems like a good candidate to get committed in. Could you see what you think please?

I don't have a multisite test environment to try this out. Maybe another committer could take a look?

This ticket was mentioned in Slack in #core by stevenkword. View the logs.


4 years ago

#8 @helen
4 years ago

  • Keywords has-patch commit removed

I'm not sure about this change - it makes the top alignment different for textarea vs. text input, although it's kind of hard to tell from the screenshot because it's annotated. If the issue is the text baseline, seems like that should be what's fixed; if it's the top alignment, then all similar inputs should be looked at.

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


4 years ago

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


4 years ago

#11 follow-up: @jeremyfelt
4 years ago

  • Milestone changed from 4.7 to Future Release

I'm going to move this back to future release until we're more sure what we want from the ticket. I'd like to see some non-annotated screenshots or similarly annotated screenshots so that it's more obvious what's being "fixed" here.

This ticket was mentioned in Slack in #core by karmatosed. View the logs.


4 years ago

#13 in reply to: ↑ 11 @Ankit K Gupta
4 years ago

Replying to jeremyfelt:

I'd like to see some non-annotated screenshots or similarly annotated screenshots so that it's more obvious what's being "fixed" here.

Attached non-annotated screenshots in Chrome and Firefox.

#14 @Ankit K Gupta
4 years ago

  • Keywords needs-refresh added

#15 @Ankit K Gupta
4 years ago

Can we consider this ticket for 4.8 ?

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

#17 @afercia
3 years ago

  • Focuses accessibility removed
Note: See TracTickets for help on using tickets.