Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#37838 closed defect (bug) (invalid)

Merge two similar translation strings in wp-activate.php

Reported by: ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: multisite Cc:

Description

See the attached patch.

Attachments (1)

37838.patch (1.4 KB) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
5 years ago

#1 @ramiy
5 years ago

  • Keywords has-patch added

This patch is:

  1. Merges the two similar translation strings into one string BUT with different placeholder variables.
  2. Removes $login_url var. It is being used once. I moved it into to the sprintf().
  3. Adds esc_url() to all the URL's.

#2 follow-up: @SergeyBiryukov
5 years ago

I think these strings are intentionally slightly different, one is for creating an account and a site, and the other is for just creating an account on the network.

Also, wp_login_url() won't work outside of switch_to_blog()/restore_current_blog() here, see [34790].

#3 @ramiy
5 years ago

@SergeyBiryukov , What do you suggest to do?

#4 @SergeyBiryukov
5 years ago

  • Focuses multisite added

#5 in reply to: ↑ 2 @flixos90
5 years ago

Replying to SergeyBiryukov:

I think these strings are intentionally slightly different, one is for creating an account and a site, and the other is for just creating an account on the network.

I agree, I don't think this should be changed for the reason you mentioned. I would say invalid.

#6 @ramiy
5 years ago

  • Keywords has-patch removed
  • Resolution set to invalid
  • Status changed from new to closed

#7 @SergeyBiryukov
5 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.