Minor Parent Menu Item Deletion 'sub item' Issue

[rnoakes3rd]

When a top-level parent nav menu item is deleted in the admin, the direct children still display the 'sub item' text. After some quick research, I found that the $.fn.shiftDepthClass (line 82 of /wp-admin/js/nav-menu.js) function could be changed a bit to resolve this:

shiftDepthClass : function(change) {
	return this.each(function(){
		var t = $(this),
			depth = t.menuItemDepth(),
			new_depth = depth + change;
		t.removeClass('menu-item-depth-'+ depth )
			.addClass('menu-item-depth-'+ (new_depth) );
		if ( new_depth == 0 )
			t.find('.is-submenu').hide();
	});
}

Totally minor, but figured I would bring it up.

[swissspidy]

Hey there,

Welcome to WordPress Trac and thanks for suggesting a solution right away! It would be great to have that snippet as a patch so we could more easily test it.

Are you familiar with working with patches? There's a good ​handbook entry about creating and testing patches.

[rnoakes3rd]

Patch for the unminified /wp-admin/js/nav-menu.js file.

[rnoakes3rd]

Thank you, Pascal! I have attached the patch. I change the code a bit to better follow the coding standards used throughout the file. Please let me know if there are any issues.

Robert

[adamsilverstein]

@rnoakes3rd Thanks for the patch, works great!

I tested this and verified it fixes the issue you noted.

Here is a screencast as a visual record:

• before the patch: ​https://cl.ly/0X3R1e1M3z32/screencast_2016-08-31_11-46-05.mp4
• after the patch: ​https://cl.ly/3T1g0e2M3y0y/screencast_2016-08-31_11-48-57.mp4

I also tested the patch with multiple level menus and everything worked as expected.

ps. Please note that for consistency we generate patches one folder up from where you where, the trunk folder of the WordPress development repository. I am uploading an updated patch. I also added a bit more whitespace inside parentheses (only for the code we are touching and despite the nearby non spaced code), following the ​WordPress JavaScript coding standards.

[rnoakes3rd]

Thank you for the info, Adam! I'm glad the patch worked. Looking at the code, those parentheses could probably be removed since there is no math occurring there anymore, but they aren't hurting anything. More of an oversight on my part :)

[swissspidy]

In 38612:

Menus: Remove 'sub item' label when removing the sub item's parent.

Props rnoakes3rd, adamsilverstein.
Fixes #37846.

[swissspidy]

In 38613:

Menus: Use strict comparison for the condition added in [38612].

See #37846.