WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 7 years ago

#37860 closed defect (bug) (worksforme)

Labels are misplaced with respect to text box.

Reported by: juhise's profile juhise Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: Upgrade/Install Keywords: has-patch has-screenshots
Focuses: ui, administration Cc:

Description

On plugin-install.php and theme-install.php. Labels on favorites tab seem not aligned.
Labels and text box should appear same align.

Attachments (4)

37860.patch​ (322 bytes) - added by juhise 10 years ago.
attached patch
theme.png​ (11.5 KB) - added by juhise 10 years ago.
screen shot of theme page
AfterFix.png​ (17.9 KB) - added by juhise 10 years ago.
alingment.png​ (93.3 KB) - added by karmatosed 8 years ago.

Download all attachments as: .zip

Change History (18)

@juhise
10 years ago

attached patch

@juhise
10 years ago

screen shot of theme page

@juhise
10 years ago

#1 @juhise
10 years ago

  • Keywords has-patch added

#2 @swissspidy
10 years ago

  • Focuses accessibility removed
  • Keywords has-screenshots added
  • Milestone changed from Awaiting Review to 4.7

#3 @karmatosed
10 years ago

  • Keywords ui-feedback added

This looks like a great fix @juhise, good catch. I'm a little concerned with changing things though. The reason is that all our forms have the similar issue by vertical-aligning on the middle. For example you can see this in the General Settings on all fields.

It maybe raises the consideration of if we should have a global change or we should leave things as they are for consistency. I'd probably suggest in this case we kept everything to the same vertical-align. However, lets try and get some other opinions apart from mine on this and I'll raise it in this week's design meeting.

Version 0, edited 10 years ago by karmatosed (next)

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
10 years ago

This ticket was mentioned in ​Slack in #core by stevenkword. ​View the logs.
9 years ago

#6 @stevenkword
9 years ago

This relates to #37822and should probably be handled with the same solution.

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
9 years ago

#8 @karmatosed
9 years ago

  • Milestone changed from 4.7 to Future Release

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
9 years ago

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
8 years ago

@karmatosed
8 years ago

#12 @karmatosed
8 years ago

I think the above image may show this has been resolved. Please can I get a confirmation that is the case?

Last edited 8 years ago by karmatosed (previous) (diff)

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
7 years ago

#14 @karmatosed
7 years ago

  • Keywords ui-feedback removed

Removing feedback keyword as this has feedback.

#15 @karmatosed
7 years ago

  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed

This does seem to be resolved so for now closing, we can always reopen.

Note: See TracTickets for help on using tickets.