WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 12 months ago

#37861 new enhancement

Renaming of class files for consistency

Reported by: afragen Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bootstrap/Load Keywords: dev-feedback
Focuses: Cc:

Description

I'm not sure how relevant this is in general, but with #36335 shouldn't we at least follow the naming convention for the few class files left?

A quick glance shows

wp-includes/class.wp-dependencies.php -> wp-includes/class-wp-dependencies.php wp-includes/class.wp-scripts.php -> wp-includes/class-wp-scripts.php wp-includes/class.wp-styles.php -> wp-includes/class-wp-styles.php

I'm not certain what type of breakage may occur, unless someone is loading these independently of core.

Attachments (1)

37861.patch (3.8 KB) - added by schlessera 12 months ago.
Rename offending files and adapt all mentions

Download all attachments as: .zip

Change History (4)

#1 @swissspidy
19 months ago

  • Keywords dev-feedback added
  • Version 4.7 deleted

@schlessera
12 months ago

Rename offending files and adapt all mentions

#2 @desrosj
12 months ago

I am generally in favor of this, but I think we should at least scan the .org repository for any plugins including or requiring these files directly. If there are many, we need to properly communicate the change with enough notice.

Last edited 12 months ago by desrosj (previous) (diff)

#3 @swissspidy
12 months ago

I think we'd just copy the files using svn (to keep the history) and then require the new ones inside the old files for back compat. That's what was done in the past when classes were moved to other files.

Note: See TracTickets for help on using tickets.