Renaming of class files for consistency

[afragen]

I'm not sure how relevant this is in general, but with #36335 shouldn't we at least follow the naming convention for the few class files left?

A quick glance shows

wp-includes/class.wp-dependencies.php -> wp-includes/class-wp-dependencies.php
wp-includes/class.wp-scripts.php -> wp-includes/class-wp-scripts.php
wp-includes/class.wp-styles.php -> wp-includes/class-wp-styles.php

I'm not certain what type of breakage may occur, unless someone is loading these independently of core.

[schlessera]

Rename offending files and adapt all mentions

[desrosj]

I am generally in favor of this, but I think we should at least scan the .org repository for any plugins including or requiring these files directly. If there are many, we need to properly communicate the change with enough notice.

[swissspidy]

I think we'd just copy the files using svn (to keep the history) and then require the new ones inside the old files for back compat. That's what was done in the past when classes were moved to other files.

[SergeyBiryukov]

#56374 was marked as a duplicate.

[SergeyBiryukov]

Hi there, thanks for the ticket!

It's worth noting that these files are also included in the ​BackPress library, which may or may not be relevant as it does not seem to be actively supported.

I don't have a strong opinion here, but if there is a general consensus that these should be renamed for consistency, might as well do it. Moving to 6.1 for discussion.

[hellofromTonya]

@SergeyBiryukov I agree +1. Let's get these filenames consistent.

To avoid things breaking in plugins, I'm +1 for @swissspidy suggestion:

I think we'd just copy the files using svn (to keep the history) and then require the new ones inside the old files for back compat. That's what was done in the past when classes were moved to other files.

That extra step has precedence and can mitigate risks for users who have a plugin, theme or script that includes any of these renamed files.

[hellofromTonya]

I'll work on an updated patch tomorrow for consideration. Assigning ownership to me too to remind me (lol) and to help shepherd it forward in time for 6.1 feature freeze.

[SergeyBiryukov]

Replying to hellofromTonya:

I'll work on an updated patch tomorrow for consideration. Assigning ownership to me to remind me (lol) and to help shepherd it forward in time for 6.1 feature freeze.

Great! Please note that svn mv commands may not be properly reflected in a patch. See comment:33:ticket:47632 for a general procedure with these renamings.

[SergeyBiryukov]

In 54254:

Coding Standards: Rename WordPress Dependencies API class files.

The current coding standards note that the name of the class files should be based on the class name with class- prepended, and the underscores replaced by hyphens (see the ​Naming Conventions section in the handbook), except for the three legacy files: class.wp-dependencies.php, class.wp-scripts.php, class.wp-styles.php.

To bring more consistency to the codebase and make it easier to implement autoloading in the future, this commit renames those three legacy files to conform to the coding standards:

• wp-includes/class.wp-dependencies.php → wp-includes/class-wp-dependencies.php
• wp-includes/class.wp-scripts.php → wp-includes/class-wp-scripts.php
• wp-includes/class.wp-styles.php → wp-includes/class-wp-styles.php

Includes:

• Loading the new files from the old ones, for anyone that may have been including the files directly.
• Replacing references to the old filenames with the new filenames.

Follow-up to [7970], [45654], [45662], [45663], [45678], [47197], [52026], [53749].

Props afragen, schlessera, swissspidy, dingo_d, hellofromTonya, SergeyBiryukov.
Fixes #37861. See #55647.

[hellofromTonya]

Removing the changes-requested keyword as changes were applied to [54254]. Thank you everyone for your contributions to get this one over the finish line and into WP 6.1.