WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37864 closed defect (bug) (worksforme)

No shiny update when updating a plugin in a non-English site

Reported by: leemon Owned by: ocean90
Milestone: Priority: normal
Severity: major Version: 4.6
Component: Upgrade/Install Keywords:
Focuses: javascript, administration Cc:

Description

Steps to reproduce:

  1. Set "Spanish" as Site Language
  2. Click the "actualízala ahora" link in any non-updated plugin in the Plugins screen
  3. No Shiny Update, but Bleak Screen of Sadness

Attachments (1)

update.jpg (48.7 KB) - added by leemon 3 years ago.

Download all attachments as: .zip

Change History (12)

@leemon
3 years ago

#1 @johnbillion
3 years ago

  • Focuses ui removed
  • Keywords reporter-feedback added
  • Severity changed from normal to major

Thanks for the report, @leemon.

  • Are you able to take a look in PHP's error log and see if there are any errors being reported?
  • Are there any JavaScript errors being reported in your browser's console?

#2 @leemon
3 years ago

  • No errors reported in PHP's error log
  • No JS errors reported in browser's console

I've set both WP_DEBUG and SCRIPT_DEBUG to true

Last edited 3 years ago by leemon (previous) (diff)

#3 @johnbillion
3 years ago

  • Keywords needs-testing added; reporter-feedback removed

Sorry @leemon, I misunderstood your original report. The update is successfully performed, but uses the bleak old updater instead of the shiny new updater.

I've confirmed this is the case. Clicking the actualízala ahora link takes you to the bleak updates screen instead of performing a shiny update.

#4 follow-up: @johnbillion
3 years ago

  • Keywords needs-testing removed
  • Owner set to ocean90
  • Status changed from new to assigned

This appears to be an issue with the Spanish translation. It's missing the %6$s placeholder which adds the update-link class attribute which the shiny updater uses.

There's no translation listed on translate.wordpress.org for the phrase There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a> or <a href="%5$s" %6$s>update now</a>. for Spanish (es_ES), yet a translation does appear in the downloaded translation file: Hay disponible una nueva versión de %1$s. <a href=\"%2$s\" class=\"thickbox\" title=\"%3$s\">Ver los detalles de la versión %4$s</a> o <a href=\"%5$s\">actualízala ahora</a>..

@ocean90 Can you take a look? This is the third issue we've seen where a translation doesn't have the correct placeholder and it's being allowed through somehow.

Last edited 3 years ago by johnbillion (previous) (diff)

#5 @netweb
3 years ago

Tagging/Pinging the Spainish translation team: #es_ES

#6 in reply to: ↑ 4 ; follow-up: @SergeyBiryukov
3 years ago

Replying to johnbillion:

This appears to be an issue with the Spanish translation. It's missing the %6$s placeholder which adds the update-link class attribute which the shiny updater uses.

There's no translation listed on translate.wordpress.org for the phrase

It's in the admin project.

@luisrull or @bi0xid, could you change title="%3$s" to %3$s and add the missing %6$s placeholder?

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

#8 in reply to: ↑ 6 @luisrull
3 years ago

Replying to SergeyBiryukov:

Fixed also in https://translate.wordpress.org/projects/wp/dev/admin/es/default?filters[status]=either&filters[original_id]=40442&filters[translation_id]=44829960

Replying to johnbillion:

This appears to be an issue with the Spanish translation. It's missing the %6$s placeholder which adds the update-link class attribute which the shiny updater uses.

There's no translation listed on translate.wordpress.org for the phrase

It's in the admin project.

@luisrull or @bi0xid, could you change title="%3$s" to %3$s and add the missing %6$s placeholder?

#9 @leemon
3 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed

I updated the translations in some of my sites and now the plugin update links work as expected.

Note: Sorry, I marked this ticket as invalid by mistake.

Last edited 3 years ago by leemon (previous) (diff)

#10 @leemon
3 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#11 @netweb
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.