Opened 8 years ago
Closed 8 years ago
#37864 closed defect (bug) (worksforme)
No shiny update when updating a plugin in a non-English site
Reported by: | leemon | Owned by: | ocean90 |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | major | Version: | 4.6 |
Component: | Upgrade/Install | Keywords: | |
Focuses: | javascript, administration | Cc: |
Description
Steps to reproduce:
- Set "Spanish" as Site Language
- Click the "actualízala ahora" link in any non-updated plugin in the Plugins screen
- No Shiny Update, but Bleak Screen of Sadness
Attachments (1)
Change History (12)
#1
@
8 years ago
- Focuses ui removed
- Keywords reporter-feedback added
- Severity changed from normal to major
#2
@
8 years ago
- No errors reported in PHP's error log
- No JS errors reported in browser's console
I've set both WP_DEBUG and SCRIPT_DEBUG to true
#3
@
8 years ago
- Keywords needs-testing added; reporter-feedback removed
Sorry @leemon, I misunderstood your original report. The update is successfully performed, but uses the bleak old updater instead of the shiny new updater.
I've confirmed this is the case. Clicking the actualízala ahora
link takes you to the bleak updates screen instead of performing a shiny update.
#4
follow-up:
↓ 6
@
8 years ago
- Keywords needs-testing removed
- Owner set to ocean90
- Status changed from new to assigned
This appears to be an issue with the Spanish translation. It's missing the %6$s
placeholder which adds the update-link
class attribute which the shiny updater uses.
There's no translation listed on translate.wordpress.org for the phrase There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a> or <a href="%5$s" %6$s>update now</a>.
for Spanish (es_ES
), yet a translation does appear in the downloaded translation file: Hay disponible una nueva versión de %1$s. <a href=\"%2$s\" class=\"thickbox\" title=\"%3$s\">Ver los detalles de la versión %4$s</a> o <a href=\"%5$s\">actualízala ahora</a>.
.
@ocean90 Can you take a look? This is the third issue we've seen where a translation doesn't have the correct placeholder and it's being allowed through somehow.
#6
in reply to:
↑ 4
;
follow-up:
↓ 8
@
8 years ago
Replying to johnbillion:
This appears to be an issue with the Spanish translation. It's missing the
%6$s
placeholder which adds theupdate-link
class attribute which the shiny updater uses.
There's no translation listed on translate.wordpress.org for the phrase
It's in the admin project.
@luisrull or @bi0xid, could you change title="%3$s"
to %3$s
and add the missing %6$s
placeholder?
#8
in reply to:
↑ 6
@
8 years ago
Replying to SergeyBiryukov:
Replying to johnbillion:
This appears to be an issue with the Spanish translation. It's missing the
%6$s
placeholder which adds theupdate-link
class attribute which the shiny updater uses.
There's no translation listed on translate.wordpress.org for the phrase
It's in the admin project.
@luisrull or @bi0xid, could you change
title="%3$s"
to%3$s
and add the missing%6$s
placeholder?
Thanks for the report, @leemon.