Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#37884 closed defect (bug) (invalid)

WordPress disregards explicit theme settings and serves translations first

Reported by: tomasm's profile TomasM Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: I18N Keywords:
Focuses: Cc:


My theme (Tiny Framework) explicitly states to use included language files (in functions.php):

load_theme_textdomain( 'tiny-framework', get_template_directory() . '/languages' );

I would see it fit (perhaps) to use online language pack if it is 100% complete, but what actually happens - online packs are selected regardless of the existence of the local language file.

Users started to complain as after theme update suddenly their sites became only partially translated:

Slack conversation:

Change History (3)

This ticket was mentioned in Slack in #polyglots by tomasm. View the logs.

8 years ago

This ticket was mentioned in Slack in #meta-i18n by tomasm. View the logs.

8 years ago

#3 @swissspidy
8 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hey there,

Thanks for opening this ticket. I know this is currently bugging some of your users, but posting this ticket in various Slack channels right away isn't helpful for the people trying to resolve Trac tickets.

As @casiepa already pointed out on Slack, this has been an explicit change in WordPress 4.6 and it was announced well in advance. See #34213 and

Since your theme uses language packs, there's no need to keep translation files in your theme anyway, so users will benefit from the system.

I'm therefore closing this ticket as that change won't be reverted. Of course discussion can continue also on closed tickets.

Note: See TracTickets for help on using tickets.