WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#37900 closed enhancement (fixed)

Support custom dashicon for wp.mce.View.setLoader()

Reported by: danielbachhuber Owned by: azaozz
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch
Focuses: Cc:
PR Number:

Description

wp.mce.View.setError() accepts a dashicon argument, so it would be nice if wp.mce.View.setLoader() did too.

Attachments (1)

37900.patch​ (659 bytes) - added by procodewp 3 years ago.
Patch to allow wp.mce.View.setLoader() to accept a dashicon argument, or use default.

Download all attachments as: .zip

Change History (5)

#1 @iseulde
3 years ago

  • Component changed from Editor to TinyMCE

Sounds good to me.

@procodewp
3 years ago

Patch to allow wp.mce.View.setLoader() to accept a dashicon argument, or use default.

#2 @procodewp
3 years ago

  • Keywords has-patch added; needs-patch removed

#3 @azaozz
3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 38774:

TinyMCE: add support for custom dashicon for wp.mce.View.setLoader().

Props procodewp.
Fixes #37900.

#4 @azaozz
3 years ago

  • Milestone changed from Future Release to 4.7
Note: See TracTickets for help on using tickets.