Context Navigation

← Previous Ticket
Next Ticket →

#37922 closed defect (bug) (fixed)

WP_Site_Query does not have a $join query clause to compact

Reported by:	johnjamesjacoby	Owned by:	jeremyfelt
Priority:	normal	Milestone:	4.7
Component:	Networks and Sites	Version:
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	multisite

Description

The new WP_Site_Query class tries to compact() the join variable, which will never exist because there are no related tables to join against.

Recommend we either:

Add join clause & $join = ''; to get_site_ids()
Remove join from compact() statement

Attachments (2)

37922.patch (574 bytes ) - added by johnjamesjacoby 10 years ago.: Add
37922.2.patch (495 bytes ) - added by johnjamesjacoby 10 years ago.: Remove

Download all attachments as: .zip

Change History (9)

@johnjamesjacoby
10 years ago

Attachment 37922.patch added

Add

@johnjamesjacoby
10 years ago

Attachment 37922.2.patch added

Remove

#1 @johnjamesjacoby
10 years ago

Related: #37923

#2 @flixos90
10 years ago

I would say we add it in as empty as developers filtering the clauses may expect the key to exist. It also looks a bit more future-proof that way.

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.

10 years ago

#4 @flixos90
10 years ago

Keywords commit added; 2nd-opinion removed
Milestone Awaiting Review → 4.7

This can be committed, using the first patch.

Last edited 10 years ago by flixos90 (previous) (diff)

#5 @jeremyfelt
10 years ago

I think we can follow what we're doing in WP_Network_Query and make $join available to the sites_clauses filter (where it could be used) but not yet add it to the sql_clauses property (where it wouldn't yet be used).

#6 @jeremyfelt
10 years ago

Owner set to jeremyfelt
Resolution → fixed
Status new → closed

In 38631:

Multisite: Provide $join as a possible SQL clause to the sites_clauses filter.

Previously, compact() provided a non existent $join and could cause confusion for anyone attempting to extend WP_Site_Query with their own tables. This aligns with the current behavior in WP_Network_Query.

Props johnjamesjacoby.
Fixes #37922.

#7 @johnjamesjacoby
10 years ago

Good catch on not needing to add join to $sql_clauses. Thanks @jeremyfelt!

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#37922 closed defect (bug) (fixed)

WP_Site_Query does not have a $join query clause to compact

Description

Attachments (2)

Change History (9)

@johnjamesjacoby 10 years ago

@johnjamesjacoby 10 years ago

#1 @johnjamesjacoby 10 years ago

#2 @flixos90 10 years ago

This ticket was mentioned in ​Slack in #core-multisite by flixos90. ​View the logs. 10 years ago

#4 @flixos90 10 years ago

#5 @jeremyfelt 10 years ago

#6 @jeremyfelt 10 years ago

#7 @johnjamesjacoby 10 years ago

Download in other formats:

@johnjamesjacoby
10 years ago

@johnjamesjacoby
10 years ago

#1 @johnjamesjacoby
10 years ago

#2 @flixos90
10 years ago

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.

10 years ago

#4 @flixos90
10 years ago

#5 @jeremyfelt
10 years ago

#6 @jeremyfelt
10 years ago

#7 @johnjamesjacoby
10 years ago