WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#37949 closed defect (bug) (fixed)

Toolbar: Inaccessible link to about page if user can't access the dashboard

Reported by: ocean90 Owned by: ocean90
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch
Focuses: accessibility Cc:

Description

wp_admin_bar_wp_menu() uses self_admin_url( 'about.php' ) to link to the about page even if a user can't access the dashboard of the current site.

Previously: #25162/[34122]

Attachments (3)

37949.patch (1.4 KB) - added by ocean90 5 years ago.
37949.2.patch (1.8 KB) - added by ocean90 5 years ago.
See [18777] and [19166].
37949.3.patch (3.8 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (9)

@ocean90
5 years ago

@ocean90
5 years ago

See [18777] and [19166].

#1 @ocean90
5 years ago

  • Focuses accessibility added

#2 @afercia
5 years ago

Tested a bit, looks good to me :) the only thing, when there's no link the icon doesn't change color on focus. That should be possible using some crazy CSS selector, something like:
#wpadminbar .menupop div[tabindex]:focus .ab-icon:before
I guess this should go in the custom color schemes too.

@ocean90
5 years ago

#3 @ocean90
5 years ago

@afercia Thanks for testing. Added the focus selector and a test in 37949.3.patch.

#4 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 38660:

Toolbar: Update links to the about page if current user can't access the dashboard of the current site.

Add missing focus styling for menu items with an icon.

Fixes #37949.

#5 @ocean90
5 years ago

In 38661:

Toolbar: Don't run the test from [38660] for multisite.

See #37949.

#6 @ocean90
5 years ago

In 38663:

Toolbar: Split tests added in [38660] and add a multisite specific test.

See #37949.

Note: See TracTickets for help on using tickets.