When searching installed plugins "select all" checkbox fails

[corradomatt]

When on the plugin list page (installed plugins) and searching for a set of plugins the "select all" checkboxes above and below the list of plugins do not work to select all plugins in the search results.

[afercia]

@corradomatt thanks for your report and welcome to Trac! Yep, confirmed. Looks like after refreshing the search results page, then it works.

[afercia]

Oh well, after the introduction of Shiny Updates v2 in 4.6 the plugins search is now via AJAX so I guess the events need to be delegated.

[afercia]

The attached patch just delegates the click event on the body.

[corradomatt]

Ah, yeah..I noticed that the refresh fixed it too. Thanks for the quick reply @afercia

[swissspidy]

Patch works as expected.

I was going to say that this needs to be added to the themes list table in the network admin as well, but it looks like we didn't implement Ajax search there. Something for a new ticket (any volunteers?).

[Nathan Miller]

Hi all,

Thanks for the patch. Tested it and it is working. Great work.

Will let you know if there is anything else that is needing work on :)

Cheers. N

[ocean90]

Looks like $('tbody').children().children('.check-column').find(':checkbox').click( function(e) {} needs also to be delegated.

[afercia]

Replying to ocean90:

Looks like $('tbody').children().children('.check-column').find(':checkbox').click( function(e) {} needs also to be delegated.

Hm if I get it correctly that block of JS is meant to invert the selection, right? I was unaware this functionality even existed and it seems it's not communicated in the UI interface in any way. Unless I'm missing something, I'd be in favour of removing it entirely.

[swissspidy]

Replying to afercia:

Replying to ocean90:

Looks like $('tbody').children().children('.check-column').find(':checkbox').click( function(e) {} needs also to be delegated.

Hm if I get it correctly that block of JS is meant to invert the selection, right? I was unaware this functionality even existed and it seems it's not communicated in the UI interface in any way. Unless I'm missing something, I'd be in favour of removing it entirely.

That code is used for checking the boxes in combination with pressing the shift key, e.g. when clicking the 1st and shift-clicking the 5th item afterwards, checkboxes 2-4 will be checked as well.

[afercia]

Replying to swissspidy:

That code is used for checking the boxes in combination with pressing the shift key, e.g. when clicking the 1st and shift-clicking the 5th item afterwards, checkboxes 2-4 will be checked as well.

Ah that too, right! It also inverts the current selection when shift-clicking on the "Select All" checkboxes (no ;) )
Wondering how many users are aware of this

[afercia]

Refreshed patch to delegate also the other event.

[swissspidy]

In 38703:

Plugins: Fix checkbox selection when searching for installed plugins.

Since the plugin search works via Ajax, the JavaScript events need to delegated in order for the checkboxes to work properly.

Props afercia.
Fixes #37973.

[swissspidy]

In 38706:

Plugins: Fix odd typo introduced in [38703].

even should of course be event.

See #37973.