Visual mode editor is broken after update to 4.6.1

[arnolem]

The comment javascript was added in [38349] breaks the javascript code if it is minified :

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-editor.php#L1260

See attach for more information.
the patch is attached.

[arnolem]

JS Error

[arnolem]

JS Browser interpretation

[arnolem]

38000.patch

[swissspidy]

Good catch, thanks!

I think this should be fixed in 4.6.2.

[ocean90]

@arnolem Welcome to Trac and thanks for your report!

What are you using to minify the HTML in the admin?

[arnolem]

Replying to ocean90:

@arnolem Welcome to Trac and thanks for your report!

What are you using to minify the HTML in the admin?

Thanks !

I have a simple PHP function to minify all HTML elements in function.php
You can see an example here :
​http://stackoverflow.com/questions/6225351/how-to-minify-php-page-html-output#answer-6225706

You can rewrite it more simple

<?php
ob_start(function ($buffer) {
    return preg_replace([
        '/\>[^\S ]+/s',  // strip whitespaces after tags, except space
        '/[^\S ]+\</s',  // strip whitespaces before tags, except space
        '/(\s)+/s'       // shorten multiple whitespace sequences
    ], ['>','<','\\1'], $buffer);
});

[azaozz]

Replying to arnolem:

I have a simple PHP function to minify all HTML elements in function.php

I'm afraid this preg_replace() is not "up for the job". As mentioned in the comments at the link you posted, it will potentially break anything in a <script>, <pre> and <textarea> tags. There are probably better "HTML white space removers" you could use.

Of course we will fix the comment style in this inline JS, but you will probably run into more problems in the future.

[swissspidy]

Might as well be a wontfix, but changing the milestone as there's a patch for changing the comment.

[swissspidy]

@azaozz What's your opinion on this? Leaning towards wontfix, but on the other hand it would be such a minor change.

[azaozz]

Actually this inline JS will be removed in 4.7 as the fix for RTL is included in the latest TinyMCE version. We can close it after updating TinyMCE.

[azaozz]

In 38773:

TiinyMCE: update to 4.4.3, changelog: ​https://www.tinymce.com/docs/changelog/#version443-september12016

Fixes #38081, #38245, #37507, #37808 and #38000.