WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#38004 closed defect (bug) (fixed)

Light scheme background color mismatch

Reported by: trepmal Owned by: afercia
Priority: normal Milestone: 4.7
Component: Administration Version:
Severity: normal Keywords: has-patch
Cc: Focuses: ui

Description

The admin body color is #f1f1f1, as declared in common.css

In css/colors/_variables.scss, $body-background matches this value by default.

Of the 8 admin color schemes, only Light attempts to change this value (to #f5f5f5).

However, css/colors/_admin.scss, that color is applied to the background of html, not body.

This means that if you're using Light, there is a very subtle background change on any screen that requires scrolling.

Attachments (1)

38004.diff​ (315 bytes ) - added by afercia 10 years ago.

Download all attachments as: .zip

Change History (5)

#1 @swissspidy
10 years ago

  • Version trunk

#2 @afercia
10 years ago

  • Focuses ui added
  • Keywords needs-patch good-first-bug added
  • Milestone Awaiting Review → 4.7

Easier to see in the settings pages, see below:

https://cldup.com/HS-srf0GL7.png

@afercia
10 years ago

#3 @afercia
10 years ago

  • Keywords has-patch added; needs-patch good-first-bug removed
  • Owner set to afercia
  • Status new → assigned

Patch needs to be tested on the build, after running grunt colors. Clearing the browser cache may help, especially when using Chrome :)

#4 @afercia
10 years ago

  • Resolution → fixed
  • Status assigned → closed

In 38638:

Administration: Fix the main background color for the Light color scheme.

Props trepmal.
Fixes #38004.

Note: See TracTickets for help on using tickets.