WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 20 months ago

#38017 closed enhancement (fixed)

Add widget instance to remaining widget argument filters

Reported by: SergeyBiryukov Owned by: Takahashi_Fumiki
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Widgets Keywords: good-first-bug needs-testing has-patch
Focuses: Cc:

Description

In #20788 and #33944, the $instance argument was added to these filters:

  • widget_nav_menu_args
  • widget_links_args

For consistency, other widget argument filters should have it too:

  • widget_archives_dropdown_args
  • widget_archives_args
  • widget_categories_dropdown_args
  • widget_categories_args
  • widget_pages_args
  • widget_comments_args
  • widget_posts_args
  • widget_tag_cloud_args

Attachments (2)

38017.diff (6.4 KB) - added by Takahashi_Fumiki 3 years ago.
Add extra param $instance to widget's filters.
38017.2.diff (7.2 KB) - added by Takahashi_Fumiki 3 years ago.
Added since tag for each doc.

Download all attachments as: .zip

Change History (15)

@Takahashi_Fumiki
3 years ago

Add extra param $instance to widget's filters.

#1 @Takahashi_Fumiki
3 years ago

Added $instance parameters and comment about them.

  • widget_archives_dropdown_args
  • widget_archives_args
  • widget_categories_dropdown_args
  • widget_categories_args
  • widget_pages_args
  • widget_comments_args
  • widget_posts_args
  • widget_tag_cloud_args

#2 @DrewAPicture
3 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to Takahashi_Fumiki
  • Status changed from new to assigned

@Takahashi_Fumiki Thanks for the patch. Let's also add changelog entries for the new parameters added to all of these hooks.

Assigning to mark the good-first-bug as "claimed".

@Takahashi_Fumiki
3 years ago

Added since tag for each doc.

#3 @Takahashi_Fumiki
3 years ago

Hi @DrewAPicture , I added since tag.
By the way, is there any policy for deciding target version number for non-versioned ticket?
Next major release?

#4 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.8

#5 @jbpaul17
2 years ago

  • Keywords needs-testing added; has-patch removed

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#7 @jbpaul17
2 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#9 @jbpaul17
2 years ago

  • Milestone changed from 4.8 to 4.8.1

Punting to 4.8.1 per today's bug scrub.

#10 @westonruter
2 years ago

  • Milestone changed from 4.8.1 to 4.9

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


20 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


20 months ago

#13 @SergeyBiryukov
20 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41685:

Widgets: Pass $instance to widget argument filters:

  • widget_archives_dropdown_args
  • widget_archives_args
  • widget_categories_dropdown_args
  • widget_categories_args
  • widget_meta_poweredby
  • widget_pages_args
  • widget_comments_args
  • widget_posts_args
  • widget_tag_cloud_args

See [33971] for widget_links_args and [34662] for widget_nav_menu_args.

Props Takahashi_Fumiki.
Fixes #38017.

Note: See TracTickets for help on using tickets.