WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#38040 closed defect (bug) (fixed)

Untrimed space in styles in video shortcode.

Reported by: danielpietrasik Owned by: SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.6.1
Component: Shortcodes Keywords:
Focuses: Cc:

Description

http://download.qualitypixels.pl/wordpress-bug.png

The error is in wordpress/wp-includes/media.php file, line
2590:

$width_rule = sprintf( 'width: %dpx; ', $atts['width'] );

In style attribute there is a single, untrimed space which creates string like:

<div style="width: 640px; " class="wp-video">

Change History (3)

#1 @SergeyBiryukov
8 months ago

  • Component changed from Widgets to Shortcodes
  • Milestone changed from Awaiting Review to 4.7

#2 @SergeyBiryukov
8 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 38597:

Media: Remove an extra space in style attribute in wp_video_shortcode() after [30082].

Props danielpietrasik.
Fixes #38040.

#3 @SergeyBiryukov
8 months ago

In 38598:

Media: Adjust test_video_shortcode_body() after [38597].

See #38040.

Note: See TracTickets for help on using tickets.