'wp_update_nav_menu' action returns inconsistent number of arguments

[barryceelen]

The 'wp_update_nav_menu' action is fired in two places with a different amount of arguments.

• wp-includes/nav-menu.php do_action( 'wp_update_nav_menu', $menu_id, $menu_data );
• wp-admin/includes/nav-menu.php do_action( 'wp_update_nav_menu', $nav_menu_selected_id );

The first one passes along the menu id and menu data, where the second one only returns the menu id.

[keraweb]

Fix for action parameters with backwards compatibility

[jbpaul17]

Punting to 4.8.1 per today's bug scrub.

[jbpaul17]

Punting to 4.9 per today's bug scrub.

[johnbillion]

@keraweb I know we discussed this in person, but can you refresh my memory on why the changes to the menu data were needed? Thanks!

[keraweb]

@johnbillion Wow this is a while ago.
From what I see the attributes and array keys were inconsistent at two locations where the same action is used.

This fix makes it so that both locations where the action is used will pass the same parameters and take the same array keys while maintaining backwards compatibility with the original situation.

[SergeyBiryukov]

#50208 was marked as a duplicate.

[austyfrosty]

Just found out about this defect. Was listing for the action hook with two params and got a fatal error. Luckily our QA caught this before moving to PROD. Would love to see some action on this.

[vhiltunen]

Found this still while investigating why two params caused a fatal error. There's another do_action( 'wp_update_nav_menu', $menu_id ) in file wp-includes/rest-api/endpoints/class-wp-rest-menus-controller.php.

This is just a Refresh for 38057.patch

Trac ticket: https://core.trac.wordpress.org/ticket/38057

[SirLouen]

This patch needs further work. As @vhiltunen has commented there is another instance of ​this hook here

@vhiltunen, how can you trigger such error? Can you provide some reproduction instructions?

I have refreshed the patch in case anyone would like to continue to provide a solution for this.

cc @keraweb